port: skills without app ID and password #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
requested review from
axelsrz,
carlosscastro,
EricDahlvang,
johnataylor,
stevengum,
Stevenic and
a team
as code owners
joshgummersall
changed the title
joshgummersall
commented
Oct 16, 2020
joshgummersall
commented
Oct 16, 2020
joshgummersall
commented
Oct 16, 2020
joshgummersall
commented
Oct 16, 2020
joshgummersall
commented
Oct 16, 2020
joshgummersall
commented
Oct 16, 2020
libraries/botframework-connector/src/auth/jwtTokenValidation.ts
Outdated
Show resolved
Hide resolved
joshgummersall
commented
Oct 16, 2020
|
@gabog I inlined several questions, many about things that didn't seem to map 1-1 from C# to JS. Also, did you perform any extra manual testing? I discussed my manual testing strategy in the description above. |
joshgummersall
force-pushed
the
jpg/skills-without-appid-password
branch
from
52517b4 to
d77caf2
Compare
joshgummersall
force-pushed
the
jpg/skills-without-appid-password
branch
from
d77caf2 to
9683ace
Compare
joshgummersall
changed the title
joshgummersall
commented
Oct 19, 2020
joshgummersall
commented
Oct 19, 2020
stevengum
approved these changes
Oct 20, 2020
gabog
approved these changes
Oct 20, 2020
stevengum
reviewed
Oct 21, 2020
* [PORT] DialogContextMemoryScope (#2895) * added DialogContextMemoryScope * removed setMemory implementation in dialog context memory scope Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: Steven Gum <[email protected]> * exclude browser*.js from bf-connector .nycrc * other minor cleanup in bf-connector * Change vmImage to ubuntu for all JS pipelines (#2931) * Switch to ubuntu vmimage * Tweak sed commands * Add ubuntu to the other builds * Add var NoPublish * Fix NoPublish logic * Rename var to DoNotPublishPackages * Remove DoNotPublishPackages functionality. Instead we limit automatic releases to main branch. * Fix Package Names task Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Zichuan Ma <[email protected]> Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: BruceHaley <[email protected]>
stevengum
reviewed
Oct 21, 2020
stevengum
reviewed
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2860
Description
Ports the C# anonymous skill change.
Testing
Unit tests, both ported and otherwise, along with some manual validation testing using the https://github.com/microsoft/BotBuilder-Samples/tree/main/samples/javascript_nodejs/81.skills-skilldialog sample linked against this change locally.