port: update and delete activities from skill handler #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
requested review from
carlosscastro,
johnataylor,
stevengum,
Stevenic and
a team
as code owners
|
Note: this PR is based on |
joshgummersall
changed the title
joshgummersall
force-pushed
the
jpg/skills-update-delete-activities
branch
from
3e027bd to
5c3eca0
Compare
joshgummersall
force-pushed
the
jpg/skills-update-delete-activities
branch
from
5c3eca0 to
e92ced2
Compare
|
Verified this change by doing the following:
|
gabog
approved these changes
Oct 20, 2020
* [PORT] DialogContextMemoryScope (#2895) * added DialogContextMemoryScope * removed setMemory implementation in dialog context memory scope Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: Steven Gum <[email protected]> * exclude browser*.js from bf-connector .nycrc * other minor cleanup in bf-connector * Change vmImage to ubuntu for all JS pipelines (#2931) * Switch to ubuntu vmimage * Tweak sed commands * Add ubuntu to the other builds * Add var NoPublish * Fix NoPublish logic * Rename var to DoNotPublishPackages * Remove DoNotPublishPackages functionality. Instead we limit automatic releases to main branch. * Fix Package Names task Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Zichuan Ma <[email protected]> Co-authored-by: Josh Gummersall <[email protected]> Co-authored-by: BruceHaley <[email protected]>
…te-delete-activities
joshgummersall
commented
Oct 21, 2020
stevengum
reviewed
Oct 21, 2020
stevengum
approved these changes
Oct 21, 2020
Comment on lines
+329
to
+332
| // Note: the original activity ID is passed back here to provide "behavioral" parity with the C# SDK. Due to | ||
| // some inconsistent method signatures, the proper response is not propagated back through `context.updateActivity` | ||
| // so we have to manually pass this value back. | ||
| return { id: activityId }; |
There was a problem hiding this comment.
This is painful but true... Truth be told, I don't understand the scenario where I would need the activity.id of the activity I just updated (when I needed the activity.id to update it). Especially because the activity.id doesn't change on update. But we might as well take it. 😅
There was a problem hiding this comment.
We should resolve this entirely by making the updateActivity method return a response as it does in C#. I'll file a separate issue for that parity work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1995
I slightly refactored the
SkillHandlerto share more common functionality across events. A newcontinueConversationmethod is introduced that accepts acallbackparameter that itself accepts some parameters common across the various skill events.Large test diff is again due to a refactor that better leverages Sinon for mocks/expectations rather than manually patching instances and using
assert. Also, some of the test cases that used to targetprocessActivitynow targetcontinueConversation.