Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make turnContext.updateActivity return response #2937

Closed
joshgummersall opened this issue Oct 21, 2020 · 0 comments · Fixed by #2968
Closed

Make turnContext.updateActivity return response #2937

joshgummersall opened this issue Oct 21, 2020 · 0 comments · Fixed by #2968
Assignees
@joshgummersall
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete

Comments

@joshgummersall
Copy link
Contributor

See #2912 (comment) and https://github.com/microsoft/botbuilder-dotnet/blob/main/libraries/Microsoft.Bot.Builder/TurnContext.cs#L379 for details.
@joshgummersall joshgummersall added P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete parity The issue describes a gap in parity between two or more platforms. Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) labels Oct 21, 2020
@joshgummersall joshgummersall self-assigned this Oct 21, 2020
@joshgummersall joshgummersall mentioned this issue Oct 21, 2020
Merged
joshgummersall pushed a commit that referenced this issue Oct 23, 2020
Fix turnContext updateActivity signature
a1a05e5 
Fixes #2937
@joshgummersall joshgummersall mentioned this issue Oct 23, 2020
Closed
joshgummersall pushed a commit that referenced this issue Oct 26, 2020
Fix turnContext updateActivity signature
a7c8665 
Fixes #2937
joshgummersall pushed a commit that referenced this issue Oct 26, 2020
Fix turnContext updateActivity signature
a05726b 
Fixes #2937
joshgummersall pushed a commit that referenced this issue Oct 27, 2020
Fix turnContext updateActivity signature
72c09e3 
Fixes #2937
joshgummersall pushed a commit that referenced this issue Oct 27, 2020
Fix turnContext updateActivity signature
bfa4bbf 
Fixes #2937
joshgummersall pushed a commit that referenced this issue Oct 27, 2020
Fix turnContext updateActivity signature
e752aa5 
Fixes #2937
joshgummersall pushed a commit that referenced this issue Oct 27, 2020
Fix turnContext updateActivity signature
31b96ec 
Fixes #2937
@joshgummersall joshgummersall mentioned this issue Oct 27, 2020
Merged
joshgummersall pushed a commit that referenced this issue Oct 28, 2020
Fix turnContext updateActivity signature
7603060 
Fixes #2937
joshgummersall pushed a commit that referenced this issue Oct 30, 2020
Fix turnContext updateActivity signature
37c2468 
Fixes #2937
stevengum pushed a commit that referenced this issue Oct 31, 2020
@joshgummersall
fix: turnContext updateActivity signature (#2968)
9e3a737 
* Fix turnContext updateActivity signature

Fixes #2937

* Make updateActivity async for rejection behavior

* Revert any -> unknown fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshgummersall joshgummersall

Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms. Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Milestone
No milestone
1 participant
@joshgummersall