Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I can Update and Delete activities from a Skill (JS) #1995

Closed
clearab opened this issue Apr 3, 2020 · 2 comments · Fixed by #2912
Closed

I can Update and Delete activities from a Skill (JS) #1995

clearab opened this issue Apr 3, 2020 · 2 comments · Fixed by #2912
Assignees
@joshgummersall
Labels
Area: Skills The issue is related to skills feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Milestone
R11

Comments

@clearab
Copy link
Contributor

clearab commented Apr 3, 2020 •
edited
Loading

See parent
@github-actions github-actions bot added the parent label Apr 3, 2020
@clearab clearab added P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020 Skills labels Apr 3, 2020
@clearab clearab mentioned this issue Apr 3, 2020
Closed
6 tasks
@stevengum stevengum self-assigned this Apr 6, 2020
@stevengum stevengum added R10 Release 10 - August 17th, 2020 and removed R9 Release 9 - May 15th, 2020 labels Apr 20, 2020
@clearab clearab removed P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020 labels Apr 20, 2020
@gabog gabog added Area: Skills The issue is related to skills and removed Skills labels Sep 2, 2020
@gabog gabog changed the title Channel-specific APIs in Skills (JS) I can Update and Delete activities from a Skill (JS) Sep 28, 2020
@gabog gabog added P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete feature-request A request for new functionality or an enhancement to an existing one. labels Sep 28, 2020
@gabog gabog added this to the R11 milestone Sep 28, 2020
@stevengum
Copy link
Member

Waiting on microsoft/botbuilder-dotnet#4786 to land

@gabog
Copy link
Contributor

gabog commented Oct 15, 2020

FYI @stevengum, dotnet has been merged into master

joshgummersall pushed a commit that referenced this issue Oct 19, 2020
Update/Delete activities from skills
3e027bd 
Fixes #1995
@joshgummersall joshgummersall mentioned this issue Oct 19, 2020
Merged
@joshgummersall joshgummersall linked a pull request Oct 19, 2020 that will close this issue
port: update and delete activities from skill handler #2912
Merged
joshgummersall pushed a commit that referenced this issue Oct 19, 2020
Update/Delete activities from skills
5c3eca0 
Fixes #1995
joshgummersall pushed a commit that referenced this issue Oct 20, 2020
Update/Delete activities from skills
e92ced2 
Fixes #1995
joshgummersall added a commit that referenced this issue Oct 21, 2020
@joshgummersall @stevengum @chon219
port: update and delete activities from skill handler (#2912)
b685c12 
* Properly use RoleTypes

* Add skill roletype, cast to bandaid compiler bug?

* Port anonymous skill changes

* ChannelServiceHandler test

* AppCredentials tests

* SkillsValidation tests

* Fix ClaimsIdentity constructor

* Update/Delete activities from skills

Fixes #1995

* Add comment describing `isAuthenticated` override

* Fake response with activityId

* Stgum/q fixes (#2932)

* [PORT] DialogContextMemoryScope (#2895)

* added DialogContextMemoryScope

* removed setMemory implementation in dialog context memory scope

Co-authored-by: Josh Gummersall <[email protected]>
Co-authored-by: Steven Gum <[email protected]>

* exclude browser*.js from bf-connector .nycrc
* other minor cleanup in bf-connector

* Change vmImage to ubuntu for all JS pipelines (#2931)

* Switch to ubuntu vmimage

* Tweak sed commands

* Add ubuntu to the other builds

* Add var NoPublish

* Fix NoPublish logic

* Rename var to DoNotPublishPackages

* Remove DoNotPublishPackages functionality. Instead we limit automatic releases to main branch.

* Fix Package Names task

Co-authored-by: Steven Gum <[email protected]>

Co-authored-by: Zichuan Ma <[email protected]>
Co-authored-by: Josh Gummersall <[email protected]>
Co-authored-by: BruceHaley <[email protected]>

* Fix skill validation tests

* Fix assert message

* Fix test label

* Cleanup

Co-authored-by: Steven Gum <[email protected]>
Co-authored-by: Zichuan Ma <[email protected]>
Co-authored-by: BruceHaley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshgummersall joshgummersall

Labels
Area: Skills The issue is related to skills feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Projects
None yet
Milestone
R11
Development

Successfully merging a pull request may close this issue.

port: update and delete activities from skill handler microsoft/botbuilder-js
4 participants
@clearab @joshgummersall @gabog @stevengum