Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I can Update and Delete activities from a Skill #5788

Closed
6 tasks done
clearab opened this issue Mar 23, 2020 · 1 comment
Closed
6 tasks done

I can Update and Delete activities from a Skill #5788

clearab opened this issue Mar 23, 2020 · 1 comment
Assignees
@gabog
Labels
Area: Skills The issue is related to skills feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete

Comments

@clearab
Copy link
Contributor

clearab commented Mar 23, 2020 •
edited by gabog
Loading

Issue

SkillHandler does not currently implement OnDeleteActivityAsync and OnUpdateActivityAsync so a skill that tries to send update or delete activities will get a not implemented exception.

Proposed change

Implement SkillHandler.OnUpdateActivityAsync and SkillHandler.OnDeleteActivityAsync and create a teams sample based on sample 57.teams-conversation-bot that demonstrates how to use the feature.

Component Impact

  • SDK
  • Samples

Additional notes

If the consumer is interacting with the skill using ExpectReplies, the delete and update activities will still hit the SkillController endpoint which is a non-issue since this scenario mainly targets teams that doesn't use ExpectReplies.
TODO: need to test this in Slack if time allows.

Related

Tracking Status

Dotnet SDK (Tracked in issue)

  • PR
  • Merged

Javascript SDK (Tracked in issue)

  • PR
  • Merged

Python SDK (Tracked in issue)

  • PR
  • Merged
@clearab clearab added the Skills label Mar 23, 2020
@clearab clearab changed the title Channel-specific APIs Channel-specific APIs in Skills Mar 23, 2020
@clearab clearab added the P1 Painful if we don't fix, won't block releasing label Apr 3, 2020
This was referenced Apr 3, 2020
Closed
Closed
Closed
Closed
@clearab clearab removed the P1 Painful if we don't fix, won't block releasing label Apr 20, 2020
@Batta32 Batta32 mentioned this issue Jun 18, 2020
Closed
@gabog gabog added Area: Skills The issue is related to skills and removed Skills labels Aug 12, 2020
@gabog gabog added this to the R11 milestone Aug 13, 2020
@gabog gabog added P1 Painful if we don't fix, won't block releasing draft The issue definition is still being worked on and it is not ready to start development. labels Aug 13, 2020
@gabog gabog added the feature-request A request for new functionality or an enhancement to an existing one. label Sep 11, 2020
@gabog gabog self-assigned this Sep 21, 2020
@gabog gabog changed the title Channel-specific APIs in Skills I can Update and Delete activities from a Skills Sep 28, 2020
@gabog gabog changed the title I can Update and Delete activities from a Skills I can Update and Delete activities from a Skill Sep 28, 2020
@gabog gabog added Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete and removed draft The issue definition is still being worked on and it is not ready to start development. labels Sep 28, 2020
@gabog gabog mentioned this issue Sep 28, 2020
Closed
3 tasks
@gabog gabog removed this from the R11 milestone Sep 28, 2020
@gabog
Copy link
Contributor

gabog commented Oct 30, 2020

The work items for this issue have been completed

@gabog gabog closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabog gabog

Labels
Area: Skills The issue is related to skills feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clearab @gabog