Make QnA Maker Active Learnings Threasholds user settable #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add generation scripts and interdependency graph * change 'azure' to 'botbuilder'
* [Expression] Add formatNumber, formatEpoch and formatTicks as prebuilt functions (#3876) (#3883) * add formatNumber prebuilt function * change to string output to keep tailing zeors * Add formatEpoch and formatTicks. Removed ticks from formatDate and fixed some bugs. Fixed a bug in JSON conversion where 64 bit/double values were getting truncated. * Add tests that were dropped. * Add locale to formatNumber. * Add 1000's seperators. * fix a test case * change a test case Co-authored-by: Chris McConnell <[email protected]> Co-authored-by: Chris McConnell <[email protected]> * override OnComputeId in AdaptiveSkillDialog (#3882) * override OnComputeId in AdaptiveSkillDialog * refactor AdaptiveSkillDialog.OnComputeId() * remove superfluous parenthesis around activity * apply @Stevenic's PR feedback * Rename $kind Microsoft.SkillDialog => Microsoft.BeginSkillDialog Rename class AdaptiveSkillDialog => BeginSkillDialog Move files into actions folders replace all $kind => new $kind * Style: Async method nomenclature, missing ConfigureAwait and CancellationTokens * Rename $kind Microsoft.BeginSkillDialog => Microsoft.BeginSkill Rename class BeginSkillDialog to BeginSkill * update title for begin skill * Cancellation, nomenclature and style improvements * Cancellation tokens and propagation * merge CheckForVersionChangeAsync() * Missing cancellation tokens Co-authored-by: Shuai Wang <[email protected]> Co-authored-by: Chris McConnell <[email protected]> Co-authored-by: Tom Laird-McConnell <[email protected]> Co-authored-by: Carlos Castro <[email protected]> Co-authored-by: Carlos Castro <[email protected]>
* Fix locale bug in testadapter and conversation reference. * Add debugComposer class to make it easy to debug a composerbot
…low interruptions. If QnAMaker is interrupted end the dialog.
Fix QnAMakerDialog to handle interuption scenarios
… non-loops, don't clone on loops - just stitch things together.
DialogSet.Add: Unique dialog ids for name collisions but not for reference collisions
Merge 4.9 into master
…aced it with nuget.packaing which is many versions past the one we were using. Worse, nuget.client had a bad prerelase package pushed in 2017 that breaks install adaptive into linqpad. also fixed .dialog files which were not compliant to schema (missing actions node)
* Add dependency graph * Update README.md * Update README.md * Remove DependencyGraph folder * Update graph title * Update graph title 2 * Title tweak 3 * Fix path to graph
On my machine, this unit test fails. The issue is that the expected value is incorrect. The `CurrencyGroupSeparator` for `fr-FR` is `\x202F` not `00a0`
If the server validates that the timestamp is recent to prevent replay attacks, then this would fail.
update resultProperty descption of http request step
|
Thanks for your super quick C# PR. @cleemullins similar change for JS here: microsoft/botbuilder-js#2508 |
chrimc62
force-pushed
the
CLM/MakeQnaActiveLearningConstantsSettable
branch
from
7be43c6 to
48c32bf
Compare
cleemullins
requested review from
carlosscastro,
chrimc62,
EricDahlvang,
gabog,
garypretty,
johnataylor,
mrivera-ms and
a team
as code owners
cleemullins
added
blocked
|
New PR: #4383 |
This was referenced Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C# version of #3706.
@somigithub has promised to do the JS version tonight.