Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QnA Maker Active Learnings Thresholds user settable #2508

Merged
merged 8 commits into from
Aug 6, 2020

Conversation

somigithub
Copy link
Contributor

@somigithub somigithub commented Jul 9, 2020

Issue: microsoft/botbuilder-dotnet#3706

C# Version PR: microsoft/botbuilder-dotnet#4383

This is the JS version for the same

@somigithub somigithub requested a review from cleemullins July 9, 2020 12:07
@coveralls
Copy link

coveralls commented Jul 9, 2020

Pull Request Test Coverage Report for Build 154723

  • 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 82.847%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/qnaMakerDialog.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 154714: -0.07%
Covered Lines: 14826
Relevant Lines: 17010

💛 - Coveralls

@somigithub somigithub removed request for a team August 6, 2020 04:44
@stevengum stevengum merged commit 1f42b94 into master Aug 6, 2020
@stevengum stevengum deleted the sosatti/MakeQnaActiveLearningConstantsSettable-js branch August 6, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants