-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make QnA Maker Active Learnings Thresholds user settable #2508
Merged
stevengum
merged 8 commits into
master
from
sosatti/MakeQnaActiveLearningConstantsSettable-js
Aug 6, 2020
Merged
Make QnA Maker Active Learnings Thresholds user settable #2508
stevengum
merged 8 commits into
master
from
sosatti/MakeQnaActiveLearningConstantsSettable-js
Aug 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 154723
💛 - Coveralls |
stevengum
requested changes
Jul 28, 2020
libraries/botbuilder-ai/src/qnamaker-utils/activeLearningUtils.ts
Outdated
Show resolved
Hide resolved
…ttps://github.com/microsoft/botbuilder-js into sosatti/MakeQnaActiveLearningConstantsSettable-js
somigithub
requested review from
axelsrz,
carlosscastro,
EricDahlvang,
garypretty,
johnataylor,
mrivera-ms,
munozemilio,
Stevenic,
tomlm and
a team
as code owners
August 4, 2020 19:32
somigithub
removed request for
Stevenic,
johnataylor,
garypretty,
axelsrz,
EricDahlvang,
tomlm,
carlosscastro,
munozemilio and
mrivera-ms
August 6, 2020 04:44
cleemullins
approved these changes
Aug 6, 2020
johnataylor
approved these changes
Aug 6, 2020
stevengum
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: microsoft/botbuilder-dotnet#3706
C# Version PR: microsoft/botbuilder-dotnet#4383
This is the JS version for the same