Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make QnA Training Thresholds Configurable #3706

Closed
DavidStrickland0 opened this issue Apr 8, 2020 · 6 comments · Fixed by #4383
Closed

Make QnA Training Thresholds Configurable #3706

DavidStrickland0 opened this issue Apr 8, 2020 · 6 comments · Fixed by #4383
Assignees
@somigithub
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. R10 Release 10 - August 17th, 2020
Milestone
R10

Comments

@DavidStrickland0
Copy link

DavidStrickland0 commented Apr 8, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
We would like to actively train our QnA models more in development then in production. In production we'd like to have the standard thresholds for training. While in development we'd like very low threshholds. Practically any question that has multiple answers we'd like to train.

Describe the solution you'd like
Be great if we could set
ActiveLearningUtils.MinimumScoreForLowScoreVariation
ActiveLearningUtils.MaximumScoreForLowScoreVariation
QnAMakerDialog.maximumScoreForLowScoreVariation
From AppSettings.

Describe alternatives you've considered
Since these are currently private Constants theres not much short of a custom implementation

[enhancement]
@cleemullins cleemullins added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Apr 8, 2020
@pchoudhari
Copy link

pchoudhari commented Apr 9, 2020 •
edited
Loading

Thanks for the recommendation, @DavidStrickland0 . We will put this in our backlog. Will update with an ETA. @vipeketi

@johnataylor johnataylor added the customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. label Apr 9, 2020
@pchoudhari pchoudhari mentioned this issue Apr 10, 2020
Closed
@vipeketi vipeketi self-assigned this Apr 13, 2020
@hcyang
Copy link
Contributor

hcyang commented Apr 25, 2020

Hi @vipeketi, can you update the progress, specifically an ETA as @pchoudhari mentioned?

@vipeketi
Copy link
Contributor

By end of this month, I will be able to close the issue.

@vipeketi vipeketi mentioned this issue Apr 30, 2020
Closed
@cleemullins cleemullins added the R10 Release 10 - August 17th, 2020 label May 4, 2020
@cleemullins
Copy link
Contributor

Unfortunatly, this issue doesn't look like it will make the R9 train. The PR continues to have feedback cycles and issues. This should land in R10.

@vipeketi
Copy link
Contributor

vipeketi commented Jun 10, 2020 •
edited
Loading

js changes [QnAMaker] For overloaded GetLowScoreVariation js sdk changes. PR #2330

@somigithub
Copy link
Contributor

@cleemullins
Based on other priorities at this moment, moving this issue to backlog. No planned ETA/sprint at this moment.
Please take it out of R10 release.

@munozemilio munozemilio added this to the R10 milestone Jul 1, 2020
@cleemullins cleemullins added R11 and removed R10 Release 10 - August 17th, 2020 labels Jul 9, 2020
cleemullins added a commit that referenced this issue Jul 9, 2020
@cleemullins
Fixes the C# portion of #3706
7be43c6 
Somi has promised to do the JS version tonight.
@cleemullins cleemullins mentioned this issue Jul 9, 2020
Closed
@cleemullins cleemullins linked a pull request Jul 9, 2020 that will close this issue
Make QnA Maker Active Learnings Threasholds user settable #4251
Closed
@cleemullins cleemullins added R10 Release 10 - August 17th, 2020 and removed R11 labels Jul 9, 2020
@somigithub somigithub mentioned this issue Jul 9, 2020
Merged
chrimc62 pushed a commit that referenced this issue Jul 15, 2020
@cleemullins
Fixes the C# portion of #3706
48c32bf 
Somi has promised to do the JS version tonight.
@pchoudhari pchoudhari assigned somigithub and unassigned pchoudhari and vipeketi Aug 4, 2020
somigithub pushed a commit that referenced this issue Aug 4, 2020
Fixes the C# portion of #3706
f4baf47
@somigithub somigithub mentioned this issue Aug 4, 2020
Merged
@somigithub somigithub linked a pull request Aug 4, 2020 that will close this issue
Fixes the C# portion of #3706 #4383
Merged
cleemullins pushed a commit that referenced this issue Aug 5, 2020
@somigithub
Fixes the C# portion of #3706 (#4383)
ff975b2 
Co-authored-by: Somi Reddy Satti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somigithub somigithub

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
R10
8 participants
@hcyang @cleemullins @johnataylor @DavidStrickland0 @pchoudhari @somigithub @munozemilio @vipeketi