Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QnAMaker]Making Max and Min ScoreForLowScoreVariation Configurable #3841

Closed
wants to merge 20 commits into from
Closed

[QnAMaker]Making Max and Min ScoreForLowScoreVariation Configurable #3841

wants to merge 20 commits into from

Conversation

vipeketi
Copy link
Contributor

@vipeketi vipeketi commented Apr 30, 2020 •
edited
Loading

ActiveLearningUtils.MinimumScoreForLowScoreVariation
ActiveLearningUtils.MaximumScoreForLowScoreVariation
QnAMakerDialog.maximumScoreForLowScoreVariation
Made configurable
Issue #3706

@vipeketi
ActiveLearningUtils.MinimumScoreForLowScoreVariation
affe3a5 
ActiveLearningUtils.MaximumScoreForLowScoreVariation
QnAMakerDialog.maximumScoreForLowScoreVariation
Made configurable
tomlm
tomlm suggested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@tomlm tomlm added the changes required Reviews has requested changes to be made before approval label Apr 30, 2020
@vipeketi vipeketi requested a review from tomlm April 30, 2020 17:30
@vipeketi vipeketi removed the changes required Reviews has requested changes to be made before approval label Apr 30, 2020
@tomlm tomlm added the changes required Reviews has requested changes to be made before approval label Apr 30, 2020
@vipeketi vipeketi removed the changes required Reviews has requested changes to be made before approval label May 4, 2020
@vipeketi vipeketi requested a review from tomlm May 4, 2020 06:51
@cleemullins cleemullins added the R10 Release 10 - August 17th, 2020 label May 4, 2020
@vipeketi vipeketi requested a review from tomlm May 20, 2020 19:12
@vipeketi
Copy link
Contributor Author

vipeketi commented May 20, 2020 •
edited
Loading

@tomlm please approve. #Closed

@tomlm tomlm added the changes required Reviews has requested changes to be made before approval label Jun 10, 2020
@vipeketi vipeketi removed the changes required Reviews has requested changes to be made before approval label Jun 10, 2020
@tomlm tomlm added the changes required Reviews has requested changes to be made before approval label Jun 10, 2020
@vipeketi vipeketi removed the changes required Reviews has requested changes to be made before approval label Jun 10, 2020
tomlm
tomlm reviewed Jun 11, 2020
View reviewed changes
libraries/Microsoft.Bot.Builder.AI.QnA/Dialogs/QnAMakerDialog.cs
/// </value>
/// <seealso cref="RankerTypes"/>
[JsonProperty("maximumScoreForLowScoreVariation")]
public float MaximumScoreForLowScoreVariation { get => maximumScoreForLowScoreVariation; set => maximumScoreForLowScoreVariation = value; }
Copy link
Contributor

@tomlm tomlm Jun 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float [](start = 15, length = 5)

Make this
public NumberExpression MaximumScoreForLowScoreVariation {get; set;} = 0.95F;

@tomlm
Copy link
Contributor

tomlm commented Jun 11, 2020 

    private float maximumScoreForLowScoreVariation = 0.95F;

get rid of this.

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Dialogs/QnAMakerDialog.cs:77 in f5635ed. [](commit_id = f5635ed, deletion_comment = False)

@tomlm
Copy link
Contributor

tomlm commented Jun 11, 2020 

        if (isActiveLearningEnabled && response.Answers.Any() && response.Answers.First().Score <= maximumScoreForLowScoreVariation)

var maximumScoreForLowScoreVariation = MaximumScoreForLowScoreVariation.GetValue(dc.State);

Refers to: libraries/Microsoft.Bot.Builder.AI.QnA/Dialogs/QnAMakerDialog.cs:452 in f5635ed. [](commit_id = f5635ed, deletion_comment = False)

tomlm
tomlm reviewed Jun 11, 2020
View reviewed changes
libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerDialog.schema
@@ -77,6 +77,12 @@
}
}
},
"maximumScoreForLowScoreVariation": {
"type": "float",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type": "float", [](start = 9, length = 18)

 "$ref": "[https://raw.githubusercontent.com/microsoft/botframework-sdk/master/schemas/component/definitions.schema#/definitions/numberExpression](https://raw.githubusercontent.com/microsoft/botframework-sdk/master/schemas/component/definitions.schema#/definitions/numberExpression)",

tomlm
tomlm reviewed Jun 11, 2020
View reviewed changes
libraries/Microsoft.Bot.Builder.AI.QnA/Utils/ActiveLearningUtils.cs
@@ -38,8 +38,31 @@ public static class ActiveLearningUtils
/// <returns>List of filtered qnaSearch results.</returns>
public static List<QueryResult> GetLowScoreVariation(List<QueryResult> qnaSearchResults)
{
var filteredQnaSearchResult = new List<QueryResult>();
return GetLowScoreVariation(qnaSearchResults, 95);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

95 [](start = 58, length = 2)

return GetLowScoreVariation(MaximumScoreForLowScoreVariation, MinimumScoreForLowScoreVariation,PreviousLowScoreVariationMultiplier,MaxLowScoreVariationMultiplier)

@tomlm tomlm added the changes required Reviews has requested changes to be made before approval label Jun 11, 2020
@vipeketi
Copy link
Contributor Author

Abandoning for design change.

@vipeketi vipeketi closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm requested changes

@johnataylor johnataylor Awaiting requested review from johnataylor

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

Assignees
No one assigned
Labels
changes required Reviews has requested changes to be made before approval R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vipeketi @tomlm @cleemullins