Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QnAMaker]Making Max and Min ScoreForLowScoreVariation Configurable #3841

Closed
wants to merge 20 commits into from
Closed

[QnAMaker]Making Max and Min ScoreForLowScoreVariation Configurable #3841

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
affe3a5
ActiveLearningUtils.MinimumScoreForLowScoreVariation
vipeketi Apr 30, 2020
7736570
Static fields
vipeketi Apr 30, 2020
9e05dfb
Space Format fixes
vipeketi Apr 30, 2020
3528382
JSonPoperty and documentation for Property
vipeketi Apr 30, 2020
2ab0e90
comment formatting
vipeketi Apr 30, 2020
5eb274e
Updated for maximum score for Low Score variation
vipeketi May 3, 2020
6940f68
Moved to property
vipeketi May 6, 2020
2e48980
Order modified
vipeketi May 6, 2020
0a6ef4c
made properties non-static
vipeketi Jun 3, 2020
648985b
reverting to class level
vipeketi Jun 4, 2020
1d8c0b2
format
vipeketi Jun 4, 2020
ae2ea86
changes as per review comments
vipeketi Jun 10, 2020
51eb13f
format issue
vipeketi Jun 10, 2020
fde3df2
format issues
vipeketi Jun 10, 2020
1bcac6a
formatting
vipeketi Jun 10, 2020
c5bd4ea
For SA1412
vipeketi Jun 10, 2020
290a4fe
bool
vipeketi Jun 10, 2020
6e2a5ad
For assembly contract
vipeketi Jun 10, 2020
afd342c
deleted Member variables
vipeketi Jun 10, 2020
f5635ed
Using constants for default value of parameters
vipeketi Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libraries/Microsoft.Bot.Builder.AI.QnA/Dialogs/QnAMakerDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,16 @@ public QnAMakerDialog([CallerFilePath] string sourceFilePath = "", [CallerLineNu
[JsonProperty("rankerType")]
public StringExpression RankerType { get; set; } = new StringExpression(RankerTypes.DefaultRankerType);

/// <summary>
/// Gets or sets the Maximum Score For LowScoreVariation to use.
/// </summary>
/// <value>
/// Max score for LowScoreVariation.
/// </value>
/// <seealso cref="RankerTypes"/>
[JsonProperty("maximumScoreForLowScoreVariation")]
public float MaximumScoreForLowScoreVariation { get => maximumScoreForLowScoreVariation; set => maximumScoreForLowScoreVariation = value; }
vipeketi marked this conversation as resolved.
Show resolved Hide resolved
vipeketi marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

@tomlm tomlm Jun 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float [](start = 15, length = 5)

Make this
public NumberExpression MaximumScoreForLowScoreVariation {get; set;} = 0.95F;


/// <summary>
/// Called when the dialog is started and pushed onto the dialog stack.
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions libraries/Microsoft.Bot.Builder.AI.QnA/Schemas/Microsoft.QnAMakerDialog.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@
}
}
},
"maximumScoreForLowScoreVariation": {
"type": "float",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type": "float", [](start = 9, length = 18)

 "$ref": "[https://raw.githubusercontent.com/microsoft/botframework-sdk/master/schemas/component/definitions.schema#/definitions/numberExpression](https://raw.githubusercontent.com/microsoft/botframework-sdk/master/schemas/component/definitions.schema#/definitions/numberExpression)",

"title": "maximumScoreForLowVariation",
"description": "Maximum score For Low Variation",
"default": 0.95
},
"top": {
"$ref": "https://raw.githubusercontent.com/microsoft/botframework-sdk/master/schemas/component/definitions.schema#/definitions/numberExpression",
"title": "Top",
Expand Down
18 changes: 11 additions & 7 deletions libraries/Microsoft.Bot.Builder.AI.QnA/Utils/ActiveLearningUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ namespace Microsoft.Bot.Builder.AI.QnA
/// </summary>
public static class ActiveLearningUtils
{
/// <summary>
/// Minimum Score For Low Score Variation.
/// </summary>
private const double MinimumScoreForLowScoreVariation = 20.0;

/// <summary>
/// Previous Low Score Variation Multiplier.
/// </summary>
Expand All @@ -27,9 +22,18 @@ public static class ActiveLearningUtils
private const double MaxLowScoreVariationMultiplier = 1.0;

/// <summary>
/// Maximum Score For Low Score Variation.
/// Maximum Score For Low Variation.
/// </summary>
private const double MaximumScoreForLowScoreVariation = 95.0;
private static double maximumScoreForLowScoreVariation = 95.0;

/// <summary>
/// Minimum Score For Low Variation.
/// </summary>
private static double minimumScoreForLowScoreVariation = 20.0;

public static double MaximumScoreForLowScoreVariation { get => maximumScoreForLowScoreVariation; set => maximumScoreForLowScoreVariation = value; }

public static double MinimumScoreForLowScoreVariation { get => minimumScoreForLowScoreVariation; set => minimumScoreForLowScoreVariation = value; }
vipeketi marked this conversation as resolved.
Show resolved Hide resolved
vipeketi marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// Returns list of qnaSearch results which have low score variation.
Expand Down