override OnComputeId in AdaptiveSkillDialog #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrivera-ms
approved these changes
May 6, 2020
cleemullins
approved these changes
May 7, 2020
|
Builds don't pass. :( |
Stevenic
reviewed
May 7, 2020
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Skills/AdaptiveSkillDialog.cs
Outdated
Show resolved
Hide resolved
|
The failed tests are in the socket streaming code. I'm re-running them as it's unexpected and probably transient. |
Closed
stevengum
added a commit
that referenced
this pull request
May 8, 2020
* override OnComputeId in AdaptiveSkillDialog * refactor AdaptiveSkillDialog.OnComputeId() * remove superfluous parenthesis around activity * apply @Stevenic's PR feedback
Merged
cleemullins
pushed a commit
that referenced
this pull request
May 12, 2020
* [Expression] Add formatNumber, formatEpoch and formatTicks as prebuilt functions (#3876) (#3883) * add formatNumber prebuilt function * change to string output to keep tailing zeors * Add formatEpoch and formatTicks. Removed ticks from formatDate and fixed some bugs. Fixed a bug in JSON conversion where 64 bit/double values were getting truncated. * Add tests that were dropped. * Add locale to formatNumber. * Add 1000's seperators. * fix a test case * change a test case Co-authored-by: Chris McConnell <[email protected]> Co-authored-by: Chris McConnell <[email protected]> * override OnComputeId in AdaptiveSkillDialog (#3882) * override OnComputeId in AdaptiveSkillDialog * refactor AdaptiveSkillDialog.OnComputeId() * remove superfluous parenthesis around activity * apply @Stevenic's PR feedback * Rename $kind Microsoft.SkillDialog => Microsoft.BeginSkillDialog Rename class AdaptiveSkillDialog => BeginSkillDialog Move files into actions folders replace all $kind => new $kind * Style: Async method nomenclature, missing ConfigureAwait and CancellationTokens * Rename $kind Microsoft.BeginSkillDialog => Microsoft.BeginSkill Rename class BeginSkillDialog to BeginSkill * update title for begin skill * Cancellation, nomenclature and style improvements * Cancellation tokens and propagation * merge CheckForVersionChangeAsync() * Missing cancellation tokens Co-authored-by: Shuai Wang <[email protected]> Co-authored-by: Chris McConnell <[email protected]> Co-authored-by: Tom Laird-McConnell <[email protected]> Co-authored-by: Carlos Castro <[email protected]> Co-authored-by: Carlos Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override AdaptiveSkillDialog.OnComputeId as per microsoft/botbuilder-js#2196 (with minor changes to mirror other OnComputeId overrides in C#)