override OnComputeId in AdaptiveSkillDialog (#3882)

* override OnComputeId in AdaptiveSkillDialog * refactor AdaptiveSkillDialog.OnComputeId() * remove superfluous parenthesis around activity * apply @Stevenic's PR feedback
microsoft · May 8, 2020 · f8c200b · f8c200b
1 parent f2c2f43
commit f8c200b
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Skills/AdaptiveSkillDialog.cs b/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Skills/AdaptiveSkillDialog.cs
@@ -7,6 +7,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using AdaptiveExpressions.Properties;
+using Microsoft.Bot.Builder.Dialogs.Adaptive.Templates;
 using Microsoft.Bot.Builder.Skills;
 using Microsoft.Bot.Schema;
 using Newtonsoft.Json;
@@ -161,5 +162,22 @@ public override Task<DialogTurnResult> ContinueDialogAsync(DialogContext dc, Can
 
             return base.ContinueDialogAsync(dc, cancellationToken);
         }
+
+        protected override string OnComputeId()
+        {
+            var appId = SkillAppId?.ToString() ?? string.Empty;
+            string activity;
+
+            if (Activity is ActivityTemplate at)
+            {
+                activity = StringUtils.Ellipsis(at.Template.Trim(), 30);
+            }
+            else
+            {
+                activity = StringUtils.Ellipsis(Activity?.ToString().Trim(), 30);
+            }
+
+            return $"{this.GetType().Name}['{appId}','{activity}']";
+        }
     }
 }