Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MSI to JS samples and generators #3526

Closed
MartinLuccanera opened this issue Oct 15, 2021 · 0 comments · Fixed by #3570
Closed

Add support for MSI to JS samples and generators #3526

MartinLuccanera opened this issue Oct 15, 2021 · 0 comments · Fixed by #3570
Assignees
@JuanAr
Labels
feature-request A request for new functionality or an enhancement to an existing one. P0 Must Fix. Release-blocker

Comments

@MartinLuccanera
Copy link
Contributor

MartinLuccanera commented Oct 15, 2021 •
edited by ceciliaavila
Loading

Description

Add support for User-Assigned Managed Identity (MSI) to all JS bots under the samples and generators folders. This includes source code and ARM Templates.

Bot Support Tracking

Bot essentials

Advanced bots

Authentication samples

QnA Maker samples

Teams samples

Skills samples

Language-generation folder

Generators

ARM Templates
@MartinLuccanera MartinLuccanera added P0 Must Fix. Release-blocker Size: L feature-request A request for new functionality or an enhancement to an existing one. labels Oct 15, 2021
@sw-joelmut sw-joelmut mentioned this issue Oct 20, 2021
Merged
This was referenced Oct 26, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
msomanathan pushed a commit that referenced this issue Oct 29, 2021
@ceciliaavila
[#3526] Add support for MSI to JS samples and generators - generators (…
1aa8fdd 
…#3560)

* Add MSI support to JS generators

* Fix error in generators corebot
This was referenced Oct 29, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila
[#3526] Add support for MSI to JS samples and generators - bot essent…
3e2a709 
…ials (part 1/2) (#3551)

* Add MSI support to JS 02.echo-bot

* Add MSI support to JS 03.welcome-bot

* Add MSI support to JS 05.multi-turn-prompt

* Add MSI support to JS 06.using-cards

* Add MSI support to JS 07.using-adaptive-cards

* Add MSI support to JS 08.suggested-actions
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila
[#3526] Add support for MSI to JS samples and generators - bot essent…
c0b0d42 
…ials (part 2/2) (#3552)

* Add MSI support to JS 13.core-bot

* Add MSI support to JS 14.nlp-with-orchestrator

* Add MSI support to JS 15.handling-attachments

* Add MSI support to JS 43.complex-dialog

* Add MSI support to JS 45.state-management
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila
[#3526] Add support for MSI to JS samples and generators - advanced b…
cc31887 
…ots (#3553)

* Add MSI support in JS 16.proactive-messages

* Add MSI support to JS 17.multilingual-bot

* Add MSI support to JS 19.custom-dialogs

* Add MSI support to JS 21.corebot-app-insights

* Add MSI support to JS 23.facebook-events

* Add MSI support to JS 44.prompt-for-user-input

* Add MSI support to JS 47.inspection
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila @sw-joelmut
[#3526] Add support for MSI to JS samples and generators - authentica…
d69bf35 
…tion samples (#3554)

* Add MSI support to JS 18.bot-authentication

* Add MSI support to JS 24.bot-authentication-msgraph

* Add MSI support to JS 46.teams-auth

Co-authored-by: sw-joelmut <[email protected]>
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila @sw-joelmut
[#3526] Add support for MSI to JS samples and generators - teams samp…
8fa0952 
…les (part 1/2) (#3555)

* Add MSI support in JS 25.message-reaction

* Add MSI support in JS 50.teams-messaging-extensions-search

* Add MSI support in JS 51.teams-messaging-extensions-action

* Add MSI support in JS 52.teams-messaging-extensions-search-auth-config

* Add MSI support in JS 53.teams-messaging-extensions-action-preview

Co-authored-by: sw-joelmut <[email protected]>
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila @sw-joelmut
[#3526] Add support for MSI to JS samples and generators - teams samp…
6aa4277 
…les (part 2/2) (#3556)

* Add MSI support in JS 54.teams-task-module

* Add MSI support in JS 55.teams-link-unfurling

* Add MSI support in JS 56.teams-file-upload

* Add MSI support in JS 57.teams-conversation-bot

* Add MSI support in JS 58.teams-start-new-thread-in-channel

Co-authored-by: sw-joelmut <[email protected]>
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila @MartinLuccanera
[#3526] Add support for MSI to JS samples and generators - QnA samples (
597bd0c 
#3557)

* Updating QnA for MSI

* Applying feedback

Co-authored-by: Martin Luccanera <[email protected]>
mrivera-ms pushed a commit that referenced this issue Nov 1, 2021
@ceciliaavila @sw-joelmut
[#3526] Add support for MSI to JS samples and generators - Skills sam…
a718269 
…ples (#3558)

* Add MSI support to JavaScript for Host and Skill in 81.skills-skilldialog folder

* Add MSI support to JavaScript for Host and Skill in 80.skills-simple-bot-to-bot folder

* Improve ValidTokenIssuers and ConversationId based on DotNet's implementation

Co-authored-by: sw-joelmut <[email protected]>
mrivera-ms pushed a commit that referenced this issue Nov 3, 2021
@ceciliaavila @MartinLuccanera
[#3526] Add support for MSI to JS samples and generators - language-g…
9dac0f0 
…eneration samples (#3559)

* Adding CloudAdapter to 05.a.multi-turn-prompt-with-language-fallback and fixing linter errors

* Add MSI support to JS language-generation samples

Co-authored-by: Martin Luccanera <[email protected]>
This was referenced Nov 16, 2021
Merged
Merged
mrivera-ms pushed a commit that referenced this issue Nov 16, 2021
@ceciliaavila
[#3526] Update JS samples to 4.15.0 (part 2/2) (#3598)
0892f3f 
* Update JS samples to 4.15.0 (2/2)

* Update generators to 4.15.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
feature-request A request for new functionality or an enhancement to an existing one. P0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
2 participants
@JuanAr @MartinLuccanera