Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3526] Add support for MSI to JS samples and generators - advanced bots #3553

Merged
merged 7 commits into from
Nov 1, 2021
Merged

[#3526] Add support for MSI to JS samples and generators - advanced bots #3553

merged 7 commits into from
Nov 1, 2021

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #3526

Description

This PR updates the advanced bots samples, adding support for MSI and SingleTenant App types.

Detailed Changes

  • Updated the botbuilder dependency to the RC0 version.
  • Updated index.js to pass the new parameters AppType and AppTenantId to the ConfigurationServiceClientCredentialFactory instance.
  • Added the new settings MicrosoftAppType and MicrosoftAppTenantId to the env file.

This PR updates the following samples:

  • 16.Proactive messages
  • 17.Multilingual bot
  • 19.Custom dialogs
  • 21.Application Insights
  • 23.Facebook events
  • 44.Basic custom prompts
  • 47.Inspection middleware

Testing

The following images show one of the samples, the 17.Multilingual bot, working with the three app types: MultiTenant, SingleTenant, and MSI.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner October 26, 2021 16:29
@msomanathan
Copy link

@joshgummersall / @munozemilio - Could one of you please help review this PR? Thanks!

@ceciliaavila ceciliaavila mentioned this pull request Oct 28, 2021
Closed
@mrivera-ms mrivera-ms merged commit cc31887 into main Nov 1, 2021
@mrivera-ms mrivera-ms deleted the southworks/add/msi-support-js-advanced branch November 1, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@tracyboehrer tracyboehrer Awaiting requested review from tracyboehrer tracyboehrer was automatically assigned from microsoft/bb-samples

@Virtual-Josh Virtual-Josh Awaiting requested review from Virtual-Josh Virtual-Josh was automatically assigned from microsoft/bb-samples

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceciliaavila @msomanathan @joshgummersall @mrivera-ms