Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3526] Add support for MSI to JS samples and generators - ARM preexisting RG parameters (1/2) #3565

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #3526

Description

This PR updates the JS samples' ARM preexisting-rg-parameters.json files to include the parameters required to support MSI.

Detailed Changes

  • Added appType, tenantId, existingUserAssignedMSIName, and existingUserAssignedMSIResourceGroupName to the preexisting-rg-parameters.json files.
  • Added the missing file in samples 25.message-reaction and 46.teams-auth.

Testing

This image shows the bots being deployed and tested successfully after the changes.
image

@msomanathan
Copy link

@BruceHaley - Could you please review this PR? Thanks!

@mrivera-ms mrivera-ms merged commit 27601b3 into main Nov 3, 2021
@mrivera-ms mrivera-ms deleted the southworks/add/msi-js-arm-preex-rg-param-1 branch November 3, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants