fix: botFrameworkClientFetchImpl function missing headers from Zod validation #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1381148946
💛 - Coveralls |
|
|
||
| const response = await axios.post(url, JSON.parse(body), { | ||
| headers: z.record(z.string()).parse(init.headers ?? {}), | ||
| headers: z.record(z.string()).parse(headers ?? {}), |
There was a problem hiding this comment.
headers should already be typed properly from the changes on line 16, so you should just be able to do { headers }
There was a problem hiding this comment.
Thanks, @joshgummersall, feedback applied!
libraries/botframework-connector/src/auth/botFrameworkClientImpl.ts
Outdated
Show resolved
Hide resolved
joshgummersall
approved these changes
Oct 25, 2021
joshgummersall
pushed a commit
that referenced
this pull request
Oct 26, 2021
…lidation (#3959) * Fix Zod missing headers validation error * Remove nullish coalescing operator for headers * Clean up botFrameworkClientFetchImpl headers validation * Update botFrameworkClientImpl.ts Co-authored-by: MartLuc <[email protected]>
joshgummersall
pushed a commit
that referenced
this pull request
Oct 28, 2021
#3963) * fix: botFrameworkClientFetchImpl function missing headers from Zod validation (#3959) * Fix Zod missing headers validation error * Remove nullish coalescing operator for headers * Clean up botFrameworkClientFetchImpl headers validation * Update botFrameworkClientImpl.ts Co-authored-by: MartLuc <[email protected]> * fix: add more release branches Co-authored-by: Joel Mut <[email protected]> Co-authored-by: MartLuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #minor
Description
This PR fixes an issue when the
Hostwants to send anActivityto theSkillusing the internalbotFrameworkClientFetchImplfunction to make thePOSTrequest.This validation error was found as part of the issue BotBuilder-Samples-#3526 to add support for MSI to the JavaScript samples, that currently is under development.
Specific Changes
botFrameworkClientFetchImplfunction, thezodvalidation fails to recognize the keys from theheadersobject.Testing
The following images show the error and the bots working after the fix.
