This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Refactor Calls components into smaller pieces for future Widgets work #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Palid
added
T-Defect
Palid
force-pushed
the
jitsi-picture-in-picture
branch
from
56f9430 to
b19ed64
Compare
Palid
commented
Jul 26, 2021
dbkr
removed
the
T-Enhancement
|
Have removed T-Enhancement: I think this probably falls into bugfix, but it definitely shouldn't be both :) |
germain-gg
reviewed
Jul 26, 2021
Palid
force-pushed
the
jitsi-picture-in-picture
branch
from
2bf64f9 to
f4061f0
Compare
This was referenced Jul 27, 2021
Palid
force-pushed
the
jitsi-picture-in-picture
branch
2 times, most recently
from
2f5b87a to
59b6f56
Compare
Palid
removed
the
T-Defect
Palid
force-pushed
the
jitsi-picture-in-picture
branch
from
59b6f56 to
9c89a13
Compare
Palid
changed the title
Palid
force-pushed
the
jitsi-picture-in-picture
branch
from
9c89a13 to
ae411b9
Compare
|
@SimonBrandner here's the small refactor that we can probably improve upon in the future when normalizing the widgets rendering. |
SimonBrandner
suggested changes
Aug 3, 2021
Co-authored-by: Šimon Brandner <[email protected]>
Co-authored-by: Šimon Brandner <[email protected]>
Co-authored-by: Šimon Brandner <[email protected]>
Co-authored-by: Šimon Brandner <[email protected]>
Palid
force-pushed
the
jitsi-picture-in-picture
branch
from
6f29b09 to
b18d03b
Compare
…icture * origin/develop: (100 commits) Add comments to isRegionalIndicator Stop voice messages that are playing when starting a recording Properly set style attribute on shared usercontent iframe Fix in-call context menus when in PiP mode (#6552) Extract tooltipYOffset to a const Increase yOffset by 4px away i18n Post-merge conflict resolution and improve alignment of tooltips Fix image & blurhash info when skipping thumbnail due to thresholds Skip sending a thumbnail if it is not a sufficient saving over the original Null guard space inviter to prevent the app exploding Remove seams from pin icon Appease Jest Fix worklet reference for new webpack pipeline i18n Update copy Fix wrong cursor being used in PiP Fix voice feed cut-off Use flex-start as it has more universal support Wrap cases in {} ...
SimonBrandner
suggested changes
Aug 6, 2021
Co-authored-by: Šimon Brandner <[email protected]>
dbkr
approved these changes
Aug 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request only refactors Calls into a slightly smaller, reusable piece which will make reusing it in the future for Widgets much easier.