Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP for portrait video calls is positioned off the screen #18261

Closed
ara4n opened this issue Jul 27, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#6483
Closed

PIP for portrait video calls is positioned off the screen #18261

ara4n opened this issue Jul 27, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#6483
Assignees
@SimonBrandner
Labels
A-Picture-in-Picture A-VoIP T-Defect X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Jul 27, 2021

It then slowly creeps back onto the page when you start to interact with it
@Palid
Copy link
Contributor

Palid commented Jul 27, 2021

Related: matrix-org/matrix-react-sdk#6475

@SimonBrandner
Copy link
Contributor

This is on me, we shouldn't animate when the windows size changes

@Palid
Copy link
Contributor

Palid commented Jul 27, 2021

@SimonBrandner pretty sure it's the same (or at least very similar) problem I have in the linked PR, wanna help with figuring this out? 😄

@SimonBrandner
Copy link
Contributor

Already working on it :P

@SimonBrandner SimonBrandner self-assigned this Jul 27, 2021
@SimonBrandner SimonBrandner mentioned this issue Jul 27, 2021
Merged
@ara4n
Copy link
Member Author

ara4n commented Jul 27, 2021

for the sake of posterity, this bug looked like this:

Screenshot 2021-07-27 at 13 47 49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-Picture-in-Picture A-VoIP T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PiP resize issues SimonBrandner/matrix-react-sdk
4 participants
@germain-gg @ara4n @Palid @SimonBrandner