This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix in-call context menus when in PiP mode #6552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mounting them as children when in PiP mode doesn't work. Condition mounting the context menus as children of the current component based on whether PiP mode is active.
1 task
dbkr
added
the
T-Defect
dbkr
approved these changes
Aug 4, 2021
Whoops, meant to link this PR: #6496 |
… anoa/fix_call_buttons_pip
Palid
added a commit
that referenced
this pull request
Aug 6, 2021
…icture * origin/develop: (100 commits) Add comments to isRegionalIndicator Stop voice messages that are playing when starting a recording Properly set style attribute on shared usercontent iframe Fix in-call context menus when in PiP mode (#6552) Extract tooltipYOffset to a const Increase yOffset by 4px away i18n Post-merge conflict resolution and improve alignment of tooltips Fix image & blurhash info when skipping thumbnail due to thresholds Skip sending a thumbnail if it is not a sufficient saving over the original Null guard space inviter to prevent the app exploding Remove seams from pin icon Appease Jest Fix worklet reference for new webpack pipeline i18n Update copy Fix wrong cursor being used in PiP Fix voice feed cut-off Use flex-start as it has more universal support Wrap cases in {} ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#18382.
Mounting them as children when in PiP mode behaves oddly. Condition mounting the context menus as children of the current component based on whether PiP mode is active. Note that this is a bit of a quick fix - I don't currently know why it doesn't work in PiP mode.
Using the same changelog as #18382 (I assume these will be merged together?).
Notes: Fix DialPad and Call Menu buttons not working when a call is fullscreened.
Signed-off-by: Andrew Morgan <[email protected]>