This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix DialPad and Call Menu buttons not working when a call is fullscreened. #6496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urr. container By default, ContextMenu's are children of mx_ContextualMenu_Container, which is placed at the root of the DOM. A new prop, mountAsChild, allows for ContextMenus to be mounted as children of the current container instead. This is necessary as mx_ContextualMenu_Container won't be included in the content that's shown when a call is fullscreened, and could potentially be useful elsewhere.
anoadragon453
added
the
T-Defect
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#17175
This PR:
ContextMenuto allow menu content to be mount as a child of the current component, rather than at the root of the DOM (which was not included in the full-screen'd content).Signed-off-by: Andrew Morgan <[email protected]>