Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pop out menu in PIP is in a random location #18382

Closed
1 task
kittykat opened this issue Aug 4, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#6552
Closed
1 task

Pop out menu in PIP is in a random location #18382

kittykat opened this issue Aug 4, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#6552
Labels
A-Picture-in-Picture A-VoIP O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@kittykat
Copy link
Contributor

kittykat commented Aug 4, 2021 •
edited
Loading

Description

Assuming that the ellipsis menu is there for fancy future features, I would expect the menu that pops to to not be somewhere random.

Steps to reproduce

  • Start a call
  • Navigate to another room [call minimises to a "PIP" window]
  • Click the … button in the "PIP" window

When the "PIP" window is top right or bottom right, I get this:

Screenshot from 2021-08-04 15-24-14 Screenshot from 2021-08-04 14-53-52

When it is top left or bottom left, the … button doesn't do anything at all

Logs being sent: no

Version information

  • Platform: web (in-browser)

For the web app:

  • Browser: Chromium Version 92.0.4515.107 (Official Build)
  • OS: Arch Linux (64-bit)
  • URL: develop.element.io

Acceptance criteria for fix

  • Menu overlay behaves in a consistent way

CC: @afranke
@kittykat kittykat added T-Defect Z-Platform-Specific S-Tolerable Low/no impact on users A-VoIP Z-Papercuts Visible. Impactful. Predictable to action. A-Picture-in-Picture O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist and removed Z-Platform-Specific S-Tolerable Low/no impact on users labels Aug 4, 2021
@afranke
Copy link
Contributor

afranke commented Aug 4, 2021

Can confirm on Firefox 90.0.2, Fedora 34, develop.element.io.

Looks fine on app.element.io (where the button still have a slightly different layout).

@SimonBrandner
Copy link
Contributor

Perhaps regressed by matrix-org/matrix-react-sdk#6496

@SimonBrandner
Copy link
Contributor

Perhaps regressed by matrix-org/matrix-react-sdk#6496

Yeah, looks fine when the context menu isn't mounted as a child

@kittykat kittykat added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 4, 2021
@SimonBrandner
Copy link
Contributor

cc @anoadragon453

@anoadragon453 anoadragon453 mentioned this issue Aug 4, 2021
Merged
@anoadragon453
Copy link
Member

Indeed - thanks for reporting! I've put up a PR to fix this at matrix-org/matrix-react-sdk#6552.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Picture-in-Picture A-VoIP O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix in-call context menus when in PiP mode matrix-org/matrix-react-sdk
4 participants
@kittykat @afranke @anoadragon453 @SimonBrandner