-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to move the local video preview around a 1:1 call #18262
Comments
Related: matrix-org/matrix-react-sdk#6475 |
As far as I can tell, this is talking about the view of yourself inside the call view, so I don't think your PR has much to do with that, or am I missing something? |
@SimonBrandner yeah right, I misunderstood reading that for the first time it seems, though I think it may still be related as the solution will be very similar, or even exactly the same. |
Well, not really, with matrix-org/matrix-react-sdk#5992 there can be multiple secondary feeds at the same time. This will need some design thinking |
@gaelledel, do you have any thoughts on this? I have a certain preference for making the secondary feeds behave like a sidebar (like Discord does), which would solve this issue, IMO. I have an awfully unprofessional Figma file here but perhaps there are other solutions |
I think we're getting a little off course here - i'm just asking to be able to drag around your local video preview (of which there is only one) within the overall video frame. Currently it's wedged in the top right, whereas I might want to move it somewhere to be less distracting (or hide it entirely). I don't think this needs design, and i don't think it's related to the separate problem of how you visualise multiple remote video feeds (which @gaelledel is separately looking at in the context of full mesh video calling) |
It is a design issue because there can be multiple feeds - 2 usermedia ones and 2 screen sharing ones. I.e. one primary and max 3 secondaries atm |
Also, we have a button to hide the secondaries, if there is more than one. (all of this is coming from: matrix-org/matrix-react-sdk#5992) |
@ara4n this is a non-issue if we consider it working only for one feed, but then what the behavior should be when we go to multiple feeds from one (e.g. screen sharing + camera)? Should you be able to move all of them around? Should it just snap to one corner instead? I think that it'll be much easier to account for "good enough" user experience if we first figure out multi-feed, as @SimonBrandner stated above, so that we won't make it confusing going up with the amount of streams. Maybe the temporary solution would be to just make the button hiding preview work for all of your streams, not only secondary ones? This won't be a very impactful on the future UX methinks. |
We could make the button always visible, not only when screen-sharing, which would at least partially solve the issue |
It's frustrating that you can move the PIP around, but not the local video preview
The text was updated successfully, but these errors were encountered: