Add compaction of mutable segments for index blocks #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robskillington
force-pushed
the
r/add-compaction-of-mutable-segments
branch
from
976b8e5 to
c3962d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1197 +/- ##
======================================
Coverage 70.7% 70.7%
======================================
Files 826 826
Lines 69869 69869
======================================
Hits 49411 49411
Misses 17296 17296
Partials 3162 3162
Continue to review full report at Codecov.
|
robskillington
changed the base branch from
r/use-pilosa-roaring-bitmaps
to
r/concurrent-index-block-queries
robskillington
force-pushed
the
r/add-compaction-of-mutable-segments
branch
from
64592d1 to
632daaa
Compare
robskillington
changed the title
added 10 commits
November 28, 2018 14:21
…ced timeout tests
robskillington
force-pushed
the
r/add-compaction-of-mutable-segments
branch
2 times, most recently
from
2a4fc05 to
673ac2c
Compare
robskillington
force-pushed
the
r/add-compaction-of-mutable-segments
branch
from
673ac2c to
185c86f
Compare
Temporal functions don't properly propagate series tags (thanks to @arnikola for suggesting this as the bug!). For instance, given series: ``` coordinator_engine_datapoints{type="fetched"} 1386 coordinator_engine_datapoints{type="generated"} 104 ``` a query like increase(coordinator_engine_datapoints[5s]) will return ``` { "__name__": "coordinator_engine_datapoints", "instance": "host.docker.internal:7203", "job": "coordinator", "role": "remote" } { "__name__": "coordinator_engine_datapoints", "instance": "host.docker.internal:7203", "job": "coordinator", "role": "remote" } ``` dropping tags. Querying the same range without increase gives all tags, as expected. Fix is simple; we weren't copying tags into the new block's SeriesMetas; now we do.
* Correctly return error for failed json unmarshal * Added test for erroring on bad JSON parsing.
Adds processing for carbon queries, handling the find and query endpoints.
This also updates the carbon ingester configuration to match the default M3 ingester config where if the config is not nil, then it is used, otherwise it's not. This removes the enabled field which was rather different to how the M3 ingester config's presence or absence defines whether to use it or not.
| @@ -0,0 +1,358 @@ | |||
| // Copyright (c) 2018 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
As talked, going to leave these as a fair few were from 2018 hah.
This was referenced Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the compaction planner to constantly move mutable segments from the index block into a compacted state.