Fix tag propagation for temporal functions #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I also refactored the tests to deduplicate a bit; I thought I would need it, and figured I might as well leave it even though I didn't. |
arnikola
reviewed
Jan 18, 2019
| expectedSeriesMetas[0].Name = "t1=v1," | ||
| expectedSeriesMetas[1].Name = "t1=v2," | ||
|
|
||
| assert.Equal(t, expectedSeriesMetas, sink.Metas, "Process should pass along series meta, renaming by ID") |
arnikola
reviewed
Jan 18, 2019
| assert.Len(t, sink.Values, 4, "output from both blocks") | ||
| compareCacheState(t, bNode, bounds, []bool{false, false}, "everything removed from cache") | ||
| blks, err := bNode.cache.multiGet(bounds, 2, false) | ||
| assert.Len(t, tc.Sink.Values, 4, "output from both tc.Blocks") |
There was a problem hiding this comment.
Whoops yeah thanks.
arnikola
approved these changes
Jan 18, 2019
andrewmains12
force-pushed
the
andrewmains12/fix_temporal_tags
branch
from
0fda4ef to
2d44293
Compare
robskillington
pushed a commit
that referenced
this pull request
Jan 28, 2019
Temporal functions don't properly propagate series tags (thanks to @arnikola for suggesting this as the bug!). For instance, given series: ``` coordinator_engine_datapoints{type="fetched"} 1386 coordinator_engine_datapoints{type="generated"} 104 ``` a query like increase(coordinator_engine_datapoints[5s]) will return ``` { "__name__": "coordinator_engine_datapoints", "instance": "host.docker.internal:7203", "job": "coordinator", "role": "remote" } { "__name__": "coordinator_engine_datapoints", "instance": "host.docker.internal:7203", "job": "coordinator", "role": "remote" } ``` dropping tags. Querying the same range without increase gives all tags, as expected. Fix is simple; we weren't copying tags into the new block's SeriesMetas; now we do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this bug locally today--temporal functions don't properly propagate series tags (thanks to @arnikola for suggesting this as the bug!).
For instance, given series:
a query like
increase(coordinator_engine_datapoints[5s])will returndropping tags. Query the same range without
increasegives all tags, as expected.Fix is simple; we weren't copying tags into the new block's
SeriesMetas; now we do.