Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and fix carbon and graphite docker integration test #1319

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Jan 27, 2019

This also updates the carbon ingester configuration to match the default M3 ingester config where if the config is not nil, then it is used, otherwise it's not. This removes the enabled field which was rather different to how the M3 ingester config's presence or absence defines whether to use it or not.

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #1319 into master will increase coverage by <.1%.
The diff coverage is 33.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1319     +/-   ##
========================================
+ Coverage    70.6%   70.6%   +<.1%     
========================================
  Files         811     811             
  Lines       68966   68960      -6     
========================================
+ Hits        48699   48719     +20     
+ Misses      17133   17110     -23     
+ Partials     3134    3131      -3
Flag Coverage Δ
#aggregator 80.9% <ø> (ø) ⬆️
#cluster 85.6% <ø> (ø) ⬆️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.9% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 74.6% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.8% <ø> (ø) ⬆️
#msg 75% <ø> (+0.1%) ⬆️
#query 64% <33.3%> (ø) ⬆️
#x 75.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8685af8...695743a. Read the comment docs.

@m3db m3db deleted a comment from codecov bot Jan 28, 2019
@m3db m3db deleted a comment from codecov bot Jan 28, 2019
@m3db m3db deleted a comment from codecov bot Jan 28, 2019
@m3db m3db deleted a comment from codecov bot Jan 28, 2019
@m3db m3db deleted a comment from codecov bot Jan 28, 2019
@m3db m3db deleted a comment from codecov bot Jan 28, 2019
@robskillington robskillington merged commit 3b4fa99 into master Jan 28, 2019
@robskillington robskillington deleted the r/add-ingester-config branch January 28, 2019 01:42
robskillington added a commit that referenced this pull request Jan 28, 2019
This also updates the carbon ingester configuration to match the default M3 ingester config where if the config is not nil, then it is used, otherwise it's not. This removes the enabled field which was rather different to how the M3 ingester config's presence or absence defines whether to use it or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant