Add Graphite ingestion #1310
Add Graphite ingestion #1310
Conversation
richardartoul
force-pushed
the
ra/carbon-ingest
branch
from
a003971 to
ffd52ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
========================================
- Coverage 70.7% 70.7% -0.1%
========================================
Files 770 770
Lines 64716 64747 +31
========================================
+ Hits 45776 45783 +7
- Misses 15978 15997 +19
- Partials 2962 2967 +5
Continue to review full report at Codecov.
|
| ctx context.Context, | ||
| iter DownsampleAndWriteIter, | ||
| ) error { | ||
| if d.downsampler != nil { |
There was a problem hiding this comment.
start goroutines first then do this then wait
| type: aggregated | ||
| retention: 10h | ||
| resolution: 15s | ||
| - namespace: unagg |
There was a problem hiding this comment.
nit: add a TODO to remove this once unaggregated is no longer mandatory?
| // Limits specifies limits on per-query resource usage. | ||
| Limits LimitsConfiguration `yaml:"limits"` | ||
| } | ||
|
|
||
| // CarbonConfiguration returns the carbon configuration. | ||
| func (c *Configuration) CarbonConfiguration() *CarbonConfiguration { |
There was a problem hiding this comment.
Can we make this return CarbonConfiguration instead of *CarbonConfiguration? That way it's always not nil when used as a local var returned from this method.
There was a problem hiding this comment.
ended up not needing this accessor at all. Made everything non-point and then used the getter pattern you described above.
No description provided.