Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double quotes is aumatically escaped as a part of the command #665

Closed
fjh1997 opened this issue Mar 11, 2020 · 1 comment · Fixed by #961
Closed

double quotes is aumatically escaped as a part of the command #665

fjh1997 opened this issue Mar 11, 2020 · 1 comment · Fixed by #961
Labels

Comments

@fjh1997
Copy link

fjh1997 commented Mar 11, 2020

Expected Behavior

the double quotes shouldn‘t be escaped as a part of the arguement for shell command

Current Behavior

the double quotes is escaped as a part of the arguement for shell command

Possible Solution

as gnome-terminal,It don't escape double quotes

Steps to Reproduce (for bugs)
  1. run this command
qterminal  -e '/usr/bin/gdb -q  "./ret2libc2"  -x "/tmp/gdbscript"'
  1. Then it is automatically converted to command below and executed by qterminal
Shell program: "/usr/bin/gdb -q  \"./ret2libc2\"  -x \"/tmp/gdbscript\""

  1. Then the file ./ret2libc2 and /tmp/gdbscript won't be found by gdb ,because gdb would regard it as
    \"./ret2libc2\" and \"/tmp/gdbscript\"

  2. the correct command should be /usr/bin/gdb -q "./ret2libc2" -x "/tmp/gdbscript" but not
    /usr/bin/gdb -q \"./ret2libc2\" -x \"/tmp/gdbscript\"

Context

some tools pass gdbscript file to gdb while opening a new terminal to debug,this bug would cause gdbscript file won't be passed to gdb.To solve this problem I have to choice another x-terminal-emulator such as xterm(I have tried koi8rxterm,lxterm,uxterm ,xtermand and even gnome-terminal but only qterminal has this problem ) or just change from xface to gnome,but I love qterminal,because it is beautiful.So I really hope someone would fix it.

System Information
  • Distribution & Version: 5.4.0-kali4-amd64
  • Kernel: Debian 5.4.19-1kali1
  • Qt Version: 5
  • Package version: 0.14.1
@yan12125
Copy link
Member

yan12125 commented Jun 6, 2022

Probably related: #335

tsujan added a commit that referenced this issue Jun 6, 2022
By using `QStringList` instead of `QString`.

Fixes #335 and fixes #665
tsujan added a commit that referenced this issue Jun 20, 2022
By using `QStringList` instead of `QString`.

Fixes #335 and fixes #665
yan12125 pushed a commit that referenced this issue Aug 29, 2022
By using `QStringList` instead of `QString`.

Fixes #335 and fixes #665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants