Fixed command parsing with -e option

By using `QStringList` instead of `QString`. Fixes #335 and fixes #665
lxqt · Jun 6, 2022 · 6687302 · 6687302
1 parent c813391
commit 6687302
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 30 deletions.
diff --git a/src/main.cpp b/src/main.cpp
@@ -72,7 +72,7 @@ QTerminalApp * QTerminalApp::m_instance = nullptr;
     exit(code);
 }
 
-void parse_args(int argc, char* argv[], QString& workdir, QString & shell_command, out bool& dropMode)
+void parse_args(int argc, char* argv[], QString& workdir, QStringList & shell_command, out bool& dropMode)
 {
     int next_option;
     dropMode = false;
@@ -87,13 +87,13 @@ void parse_args(int argc, char* argv[], QString& workdir, QString & shell_comman
                 workdir = QString::fromLocal8Bit(optarg);
                 break;
             case 'e':
-                shell_command = QString::fromLocal8Bit(optarg);
+                shell_command << QString::fromLocal8Bit(optarg);
                 // #15 "Raw" -e params
                 // Passing "raw" params (like konsole -e mcedit /tmp/tmp.txt") is more preferable - then I can call QString("qterminal -e ") + cmd_line in other programs
                 while (optind < argc)
                 {
                     //printf("arg: %d - %s\n", optind, argv[optind]);
-                    shell_command += QLatin1Char(' ') + QString::fromLocal8Bit(argv[optind++]);
+                    shell_command << QString::fromLocal8Bit(argv[optind++]);
                 }
                 break;
             case 'd':
@@ -141,7 +141,8 @@ int main(int argc, char *argv[])
         app->registerOnDbus();
     #endif
 
-    QString workdir, shell_command;
+    QString workdir;
+    QStringList shell_command;
     bool dropMode;
     parse_args(argc, argv, workdir, shell_command, dropMode);
 

diff --git a/src/properties.h b/src/properties.h
@@ -50,7 +50,7 @@ class Properties
         QPoint mainWindowPosition;
         QByteArray mainWindowState;
         //ShortcutMap shortcuts;
-        QString shell;
+        QStringList shell;
         QFont font;
         QString colorScheme;
         QString guiStyle;

diff --git a/src/terminalconfig.cpp b/src/terminalconfig.cpp
@@ -8,7 +8,7 @@
 #include "properties.h"
 #include "termwidget.h"
 
-TerminalConfig::TerminalConfig(const QString & wdir, const QString & shell)
+TerminalConfig::TerminalConfig(const QString & wdir, const QStringList & shell)
 {
     m_workingDirectory = wdir;
     m_shell = shell;
@@ -32,28 +32,28 @@ QString TerminalConfig::getWorkingDirectory()
     return QTerminalApp::Instance()->getWorkingDirectory();
 }
 
-QString TerminalConfig::getShell()
+QStringList TerminalConfig::getShell()
 {
-    if (!m_shell.trimmed().isEmpty())
-        return m_shell.trimmed();
-    if (!Properties::Instance()->shell.trimmed().isEmpty())
-        return Properties::Instance()->shell.trimmed();
+    if (!m_shell.isEmpty())
+        return m_shell;
+    if (!Properties::Instance()->shell.isEmpty())
+        return Properties::Instance()->shell;
     QByteArray envShell = qgetenv("SHELL");
     if (envShell.constData() != nullptr)
     {
         QString shellString = QString::fromLocal8Bit(envShell).trimmed();
         if (!shellString.isEmpty())
-            return shellString;
+            return QStringList{shellString};
     }
-    return QString();
+    return QStringList();
 }
 
 void TerminalConfig::setWorkingDirectory(const QString &val)
 {
     m_workingDirectory = val;
 }
 
-void TerminalConfig::setShell(const QString &val)
+void TerminalConfig::setShell(const QStringList &val)
 {
     m_shell = val;
 }
@@ -87,16 +87,23 @@ static QString variantToString(const QVariant& variant, QString &defaultVal)
     return defaultVal;
 }
 
+static QStringList variantToStringList(const QVariant& variant, QStringList &defaultVal)
+{
+    if (variant.type() == QVariant::StringList)
+        return qvariant_cast<QStringList>(variant);
+    return defaultVal;
+}
+
 TerminalConfig TerminalConfig::fromDbus(const QHash<QString,QVariant> &termArgs)
 {
     QString wdir = QString();
-    QString shell(Properties::Instance()->shell);
+    QStringList shell(Properties::Instance()->shell);
     if (termArgs.contains(QLatin1String(DBUS_ARG_WORKDIR)))
     {
         wdir = variantToString(termArgs[QLatin1String(DBUS_ARG_WORKDIR)], wdir);
     }
     if (termArgs.contains(QLatin1String(DBUS_ARG_SHELL))) {
-        shell = variantToString(termArgs[QLatin1String(DBUS_ARG_SHELL)], shell);
+        shell = variantToStringList(termArgs[QLatin1String(DBUS_ARG_SHELL)], shell);
     }
     return TerminalConfig(wdir, shell);
 }

diff --git a/src/terminalconfig.h b/src/terminalconfig.h
@@ -11,15 +11,15 @@ class TermWidget;
 class TerminalConfig
 {
     public:
-        TerminalConfig(const QString & wdir, const QString & shell);
+        TerminalConfig(const QString & wdir, const QStringList & shell);
         TerminalConfig(const TerminalConfig &cfg);
         TerminalConfig();
 
         QString getWorkingDirectory();
-        QString getShell();
+        QStringList getShell();
 
         void setWorkingDirectory(const QString &val);
-        void setShell(const QString &val);
+        void setShell(const QStringList &val);
         void provideCurrentDirectory(const QString &val);
 
         #ifdef HAVE_QDBUS
@@ -29,10 +29,10 @@ class TerminalConfig
 
 
     private:
-    	// True when 
+    	// True when
     	QString m_currentDirectory;
     	QString m_workingDirectory;
-        QString m_shell;
+        QStringList m_shell;
 };
 
-#endif
+#endif
diff --git a/src/termwidget.cpp b/src/termwidget.cpp
@@ -55,16 +55,13 @@ TermWidgetImpl::TermWidgetImpl(TerminalConfig &cfg, QWidget * parent)
 
     setWorkingDirectory(cfg.getWorkingDirectory());
 
-    QString shell = cfg.getShell();
+    QStringList shell = cfg.getShell();
     if (!shell.isEmpty())
     {
-        //qDebug() << "Shell program:" << shell;
-        QStringList parts = shell.split(QRegExp(QStringLiteral("\\s+")), Qt::SkipEmptyParts);
-        //qDebug() << parts;
-        setShellProgram(parts.at(0));
-        parts.removeAt(0);
-        if (parts.count())
-            setArgs(parts);
+        setShellProgram(shell.at(0));
+        shell.removeAt(0);
+        if (!shell.isEmpty())
+            setArgs(shell);
     }
 
     setMotionAfterPasting(Properties::Instance()->m_motionAfterPaste);