Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qterminal execution breaks up arguments #335

Closed
Vladimir-csp opened this issue May 27, 2017 · 7 comments · Fixed by #961
Closed

qterminal execution breaks up arguments #335

Vladimir-csp opened this issue May 27, 2017 · 7 comments · Fixed by #961
Labels
bug

Comments

@Vladimir-csp
Copy link

Arguments passed to qterminal -e are not properly preserved.
You may compare the behavior to xterm:

xterm -e nano "some file with spaces"\ and\ unquoted\ spaces second\ file
qterminal -e nano "some file with spaces"\ and\ unquoted\ spaces second\ file

xterm properly sends two arguments to nano, qterminal sends nine.
@yan12125 yan12125 added the bug label May 27, 2017
@yan12125
Copy link
Member

Yep - m_shell of TerminalConfig should use QStringList instead of QString

@Vladimir-csp Vladimir-csp mentioned this issue Jun 3, 2017
Closed
@yan12125 yan12125 mentioned this issue May 25, 2019
Closed
yan12125 pushed a commit that referenced this issue Jan 2, 2021
Correctly pass arguments to the shell
9006e6e 
The following command works; needs more testing

./build/qterminal -e nvim -p "some file with spaces"\ and\ unquoted\
spaces second\ file

Fixes #335
yan12125 pushed a commit that referenced this issue Jan 2, 2021
Correctly pass arguments to the shell
3bc755f 
The following command works; dbus stuffs and maybe more needs testing

./build/qterminal -e nvim -p "some file with spaces"\ and\ unquoted\
spaces second\ file

Fixes #335
@yan12125 yan12125 mentioned this issue Mar 2, 2021
Closed
@AlexanderZhirov
Copy link

Wow ... the bug has been hanging since May 27, 2017, it hasn't been fixed yet.

@tsujan
Copy link
Member

tsujan commented Mar 4, 2021

the bug has been hanging since May 27, 2017, it hasn't been fixed yet.

PRs would be appreciated; tautology wouldn't.

@AlexanderZhirov
Copy link

So does the problem have a solution or not? Maybe I don't quite understand what to do. The language barrier prevents me from understanding.

@stefonarch
Copy link
Member

It has sure a solution, but it's not so easy to implement (as @yan12125 wrote).

This was referenced Jun 6, 2022
Closed
Closed
tsujan added a commit that referenced this issue Jun 6, 2022
@tsujan
Fixed command parsing with -e option
6687302 
By using `QStringList` instead of `QString`.

Fixes #335 and fixes #665
@tsujan tsujan mentioned this issue Jun 6, 2022
Merged
@tsujan
Copy link
Member

tsujan commented Jun 11, 2022

Please test #961

tsujan added a commit that referenced this issue Jun 20, 2022
@tsujan
Fixed command parsing with -e option
c3fe003 
By using `QStringList` instead of `QString`.

Fixes #335 and fixes #665
yan12125 pushed a commit that referenced this issue Aug 29, 2022
@tsujan
Fixed command parsing with -e option
bd3ff3d 
By using `QStringList` instead of `QString`.

Fixes #335 and fixes #665
@GleammerRay
Copy link

Btw, I know that this is solved in the latest release and all but there's still people sitting with old packages because they aren't getting updated on some distros and I found a very simple way to avoid this problem.

qterminal -e has access to all environment variables so just use that.

E.g. FILE='foo bar' qterminal -e nano '$FILE' opens foo bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed command parsing with -e option lxqt/qterminal
6 participants
@tsujan @yan12125 @Vladimir-csp @stefonarch @AlexanderZhirov @GleammerRay