The double quotes around filename breaks pwnlib.debug

[jjyy1946]

I'm referencing a fix at a7678f7
This fix removed "" around the temp script name, it seems that we should also remove the "" around the exe filename as well. I tested this on kali linux with gdb 9.1 + pwntools 4.1.0:
[DEBUG] Received 0x3d bytes:
b'Process ./ropme created; pid = 62257\n'
b'Listening on port 46249\n'
[DEBUG] Wrote gdb script to '/tmp/pwndoi5fs65.gdb'
target remote 127.0.0.1:46249
b main
[*] running in new terminal: /usr/bin/gdb -q "./ropme" -x "/tmp/pwndoi5fs65.gdb"
[DEBUG] Launching a new terminal: ['/usr/bin/x-terminal-emulator', '-e', '/usr/bin/gdb -q "./ropme" -x "/tmp/pwndoi5fs65.gdb"']

From GDB:
GEF for linux ready, type gef' to start, gef config' to configure
80 commands loaded for GDB 9.1 using Python engine 3.8
"./ropme": No such file or directory.
"/tmp/pwndoi5fs65.gdb": No such file or directory.
gef➤

[zachriggle]

We should likely be using sh_string for these cases, or otherwise building an array of arguments instead of a free-form string to pass to system().

[VortixDev]

The issue necessitating this appears to relate to the following aspect of qterminal (which x-terminal-emulator is linked to): lxqt/qterminal#665. Setting context.terminal = ["xterm", "-e"] should allow you to work around the problem, for those currently affected. To fix this on my end, I've removed the quotes from the command string and run the file name through bash's printf with the %q formatter (https://stackoverflow.com/questions/5608112/escape-filenames-the-same-way-bash-does-it). I'm unsure if there's a more direct approach.

[zachriggle]

Thanks for reporting the issue! One of the guys will get on a fix for this soon! Can you tell which version was the first to show this behavior?

On Fri, Jul 3, 2020 at 7:33 AM Ryan Saridar ***@***.***> wrote: The issue necessitating this appears to relate to the following aspect of qterminal (which x-terminal-emulator is linked to): lxqt/qterminal#665 <lxqt/qterminal#665>. Setting context.terminal = ["xterm", "-e"] should allow you to work around the problem, for those currently affected. To fix this on my end, I've removed the quotes from the command string and run the file name through bash's printf with the %q formatter ( https://stackoverflow.com/questions/5608112/escape-filenames-the-same-way-bash-does-it). I'm unsure if there's a more direct approach. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1516 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA3IGA4NPUGVGSF52YKQGTRZXFYFANCNFSM4NJJYZRA> .

-- *Zach Riggle*

[VortixDev]

I'm not sure; I run qterminal 0.14.1, but it's possible that it has always behaved that way. That said, I believe Kali only started using qterminal around the start of this year.

[jjyy1946]

Sorry, really don't know, I'm new here, just start to play around. But feel free to throw me something for testing. Yi

…

On Sat, Jul 4, 2020 at 9:38 PM Zach Riggle ***@***.***> wrote: Thanks for reporting the issue! One of the guys will get on a fix for this soon! Can you tell which version was the first to show this behavior? On Fri, Jul 3, 2020 at 7:33 AM Ryan Saridar ***@***.***> wrote: > The issue necessitating this appears to relate to the following aspect of > qterminal (which x-terminal-emulator is linked to): lxqt/qterminal#665 > <lxqt/qterminal#665>. Setting context.terminal > = ["xterm", "-e"] should allow you to work around the problem, for those > currently affected. To fix this on my end, I've removed the quotes from the > command string and run the file name through bash's printf with the %q > formatter ( > https://stackoverflow.com/questions/5608112/escape-filenames-the-same-way-bash-does-it ). > I'm unsure if there's a more direct approach. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > < #1516 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAA3IGA4NPUGVGSF52YKQGTRZXFYFANCNFSM4NJJYZRA > > . > -- *Zach Riggle* — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1516 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGUAUDVMDHIQMK7IQYZHDRZ77V7ANCNFSM4NJJYZRA> .

-- Android-x86 http://www.android-x86.org