Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tool tip on allies/private button on chat #1574

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Update tool tip on allies/private button on chat #1574

merged 2 commits into from
Dec 9, 2022

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Dec 9, 2022

closes #1160

@jwrober jwrober changed the title update tooltip on allies/private button on chat Update tool tip on allies/private button on chat Dec 9, 2022
@jwrober jwrober requested a review from lmoureaux December 9, 2022 18:07
lmoureaux
lmoureaux approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like how the first conditional uses priv and the second uses cb->isChecked(), but they should be identical for all practical matters.

@jwrober
Copy link
Collaborator Author

jwrober commented Dec 9, 2022

I also noticed that the calls to getIcon() does not include QStringLiteral like we have in other areas of the code. Wonder if I should push a commit to change that.

@lmoureaux
Copy link
Contributor

I also noticed that the calls to getIcon() does not include QStringLiteral like we have in other areas of the code. Wonder if I should push a commit to change that.

We have QLatin1String which should be equivalent

@jwrober jwrober merged commit 8d86410 into longturn:master Dec 9, 2022
@jwrober jwrober deleted the bugfix/allies-button branch December 9, 2022 22:04
@jwrober jwrober mentioned this pull request Dec 9, 2022
Closed
9 tasks
@jwrober jwrober mentioned this pull request Dec 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allies only option not styled properly when checked
2 participants
@jwrober @lmoureaux