Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allies only vs public chat button still not intuitive #1646

Closed
jwrober opened this issue Dec 28, 2022 · 0 comments · Fixed by #1706
Closed

Allies only vs public chat button still not intuitive #1646

jwrober opened this issue Dec 28, 2022 · 0 comments · Fixed by #1706
Labels
enhancement New feature or request gui This issue requires changes to the user interface

Comments

@jwrober
Copy link
Collaborator

jwrober commented Dec 28, 2022

Is your feature request related to a problem? Please describe.
PR #1574 added a tool tip to try and help, but there is still confusion. For example, a megaphone icon is used for allies only and a lock type icon is used for public chat. The tool tip says what status you are currently at, and not what clicking would change the status to.

Describe the solution you'd like
A good start would be to swap the icons. Lock for allies only and megaphone for public seems more intuitive. Also maybe look at changing the tool tip to something like "click for public" or "click for allies only" to tell the user what a click action would do. It was also suggested to maybe change the push button to a drop down like menu.

Describe alternatives you've considered
Obviously what is in the game now isn't working.

Additional context
Discord https://discord.com/channels/378908274113904641/1057473087534272632/1057473087534272632
@jwrober jwrober added enhancement New feature or request gui This issue requires changes to the user interface labels Dec 28, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jan 6, 2023
@lmoureaux
Turn the "Allies Only" checkbox into a dropdown
68ce9df 
Having the two options described as text clears out the meaning without the
need to look at a hidden tooltip.

See longturn#1646.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jan 6, 2023
@lmoureaux
Add style for menu items with icons
7df28f7 
I would have preferred to see a check mark next to the icon, but this is not
possible with stylesheets. Added for the "Allies Only" menu.

See longturn#1646.
@lmoureaux lmoureaux mentioned this issue Jan 6, 2023
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jan 6, 2023
@lmoureaux
Turn the "Allies Only" checkbox into a dropdown
76133b5 
Having the two options described as text clears out the meaning without the
need to look at a hidden tooltip.

See longturn#1646.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jan 6, 2023
@lmoureaux
Add style for menu items with icons
6cecdb2 
I would have preferred to see a check mark next to the icon, but this is not
possible with stylesheets. Added for the "Allies Only" menu.

See longturn#1646.
jwrober pushed a commit that referenced this issue Jan 7, 2023
@lmoureaux @jwrober
Turn the "Allies Only" checkbox into a dropdown
fb5b702 
Having the two options described as text clears out the meaning without the
need to look at a hidden tooltip.

See #1646.
jwrober pushed a commit that referenced this issue Jan 7, 2023
@lmoureaux @jwrober
Add style for menu items with icons
5ba9d1b 
I would have preferred to see a check mark next to the icon, but this is not
possible with stylesheets. Added for the "Allies Only" menu.

See #1646.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the Allies Only button lmoureaux/freeciv21
1 participant
@jwrober