Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allies only option not styled properly when checked #1160

Closed
psampathkumar opened this issue Jul 19, 2022 · 6 comments · Fixed by #1574
Closed

Allies only option not styled properly when checked #1160

psampathkumar opened this issue Jul 19, 2022 · 6 comments · Fixed by #1574
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone

Comments

@psampathkumar
Copy link
Contributor

Describe the bug
The popup for the allies only checkbox always shows, "allies only". It is confusing given it isnt a check but has a icon change currently.

To Reproduce
Steps to reproduce the behavior:

  1. Open a game.
  2. Hover over allies only checkbox in chat widget

Expected behavior
The popup should say "broadcast globally" (or something along those lines), when allies only is enabled, and "allies only" when allies only is disabled. So that the user understands what that option goes.

Screenshots
image
image

Platform and version (please complete the following information):

  • master
@psampathkumar psampathkumar added bug Something isn't working gui This issue requires changes to the user interface labels Jul 19, 2022
@jwrober
Copy link
Collaborator

jwrober commented Jul 19, 2022

Expected behavior The popup should say "broadcast globally" (or something along those lines), when allies only is enabled, and "allies only" when allies only is disabled. So that the user understands what that option goes.

Do you mean to say that when "Allies Only" is enabled the tool tip should say so and when disabled the tool tip would say "broadcast to all" or something?

@psampathkumar
Copy link
Contributor Author

That or the other way around. Both works, like to show, "allies only" is enabled. Or to show, clicking on it will change to allies only. I am not really sure which way is better, but it should definitely be one of the two to keep things consistent.

@lmoureaux
Copy link
Contributor

It's a checkable button. The issue is that none of the themes implements the appropriate styling.

@lmoureaux lmoureaux changed the title Allies only option shows the wrong popup Allies only option not styled properly when checked Aug 13, 2022
@lmoureaux
Copy link
Contributor

Anyone willing to write some CSS for Classic and Nightstalker?

@daavko
Copy link
Collaborator

daavko commented Aug 27, 2022

I'd say the tooltip should show the current state, that's how I feel it's usually done. What would appropriate styling be here?

@lmoureaux
Copy link
Contributor

It's a checkable button, so it should look raised when unchecked and sunken when checked.

@jwrober jwrober added this to the v3.0-stable milestone Nov 27, 2022
jwrober added a commit to jwrober/freeciv21 that referenced this issue Dec 9, 2022
jwrober added a commit that referenced this issue Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants