-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allies only option not styled properly when checked #1160
Comments
Do you mean to say that when "Allies Only" is enabled the tool tip should say so and when disabled the tool tip would say "broadcast to all" or something? |
That or the other way around. Both works, like to show, "allies only" is enabled. Or to show, clicking on it will change to allies only. I am not really sure which way is better, but it should definitely be one of the two to keep things consistent. |
It's a checkable button. The issue is that none of the themes implements the appropriate styling. |
Anyone willing to write some CSS for Classic and Nightstalker? |
I'd say the tooltip should show the current state, that's how I feel it's usually done. What would appropriate styling be here? |
It's a checkable button, so it should look raised when unchecked and sunken when checked. |
Describe the bug
The popup for the allies only checkbox always shows, "allies only". It is confusing given it isnt a check but has a icon change currently.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The popup should say "broadcast globally" (or something along those lines), when allies only is enabled, and "allies only" when allies only is disabled. So that the user understands what that option goes.
Screenshots
Platform and version (please complete the following information):
The text was updated successfully, but these errors were encountered: