Various feedback and bug reports from LT75 participants #1517
Labels
enhancement
New feature or request
Milestone
Comments
daavko
added
enhancement
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Nov 26, 2022
This mostly reverts e9a0a32, because attempts at using it with Classic ended up badly. In addition to undoing these changes, this commit adds the ability to override colors in the theme configuration. Nightstalker colors will be restored in an upcoming commit. Eventually we should migrate all out-of-map colors to the themes. For now, rely on the nice-looking (with Classic) colors coming from the tilesets. Part of longturn#1517.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Nov 26, 2022
Use the opportunity to try and improve them. Part of longturn#1517.
jwrober
pushed a commit
that referenced
this issue
Nov 26, 2022
This mostly reverts e9a0a32, because attempts at using it with Classic ended up badly. In addition to undoing these changes, this commit adds the ability to override colors in the theme configuration. Nightstalker colors will be restored in an upcoming commit. Eventually we should migrate all out-of-map colors to the themes. For now, rely on the nice-looking (with Classic) colors coming from the tilesets. Part of #1517.
jwrober
pushed a commit
that referenced
this issue
Nov 26, 2022
Use the opportunity to try and improve them. Part of #1517.
Merged
That's a theme issue, it's quite clear with NightStalker. |
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Dec 4, 2022
Text on disabled buttons (such as Turn Done during turn processing) had the same color as text on active buttons (black). Gray it out when the button is disabled. Part of longturn#1517.
jwrober
pushed a commit
that referenced
this issue
Dec 4, 2022
Text on disabled buttons (such as Turn Done during turn processing) had the same color as text on active buttons (black). Gray it out when the button is disabled. Part of #1517.
|
I marked the "state of allies only button" to complete with PR #1574. While the value isn't saved between sessions, the default is always to be "public" at game start. The tooltip has been modified to tell the player if you are talking to "allies only" or to the "public". |
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Dec 9, 2022
If the turn has a fixed length, Turn Done doesn't do anything. Ignore such packets on the server. See longturn#1517.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Dec 9, 2022
"Blocking" players don't mean anything when the turn has a fixed duration. See longturn#1517.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Dec 9, 2022
This causes the "state" column in the player dialog to be updated (it uses pplayer->is_connected). See longturn#1517.
jwrober
pushed a commit
that referenced
this issue
Dec 10, 2022
If the turn has a fixed length, Turn Done doesn't do anything. Ignore such packets on the server. See #1517.
jwrober
pushed a commit
that referenced
this issue
Dec 10, 2022
"Blocking" players don't mean anything when the turn has a fixed duration. See #1517.
jwrober
pushed a commit
that referenced
this issue
Dec 10, 2022
This causes the "state" column in the player dialog to be updated (it uses pplayer->is_connected). See #1517.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this issue
Dec 12, 2022
Requested by horror-vacui on Discord. See longturn#1517.
|
With #1595 there will be a single item remaining, it's a bigger one so I propose to open an issue for it and close this one. |
psampathkumar
pushed a commit
that referenced
this issue
Dec 12, 2022
Requested by horror-vacui on Discord. See #1517.
|
The last item is here #1599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some feedback from LT75 participants, grouped into an issue so we don't forget about it. No particular order, but I added checkboxes so things can potentially be tracked as completed as necessary. Also provided links to Discord where appropriate in case more context is necessary
(network exception)is shown in the/list connectionscommand output next to player names due toclosing_reasoninconnectionobjects not being cleared when attaching a connecting player to an existingconnectionobject/takeyour nation when first connecting to a game, or it should be clearly documented that you need to do so. It causes unnecessary confusionThe text was updated successfully, but these errors were encountered: