Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear closing reason for connection object when a client connects #1519

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

daavko
Copy link
Collaborator

@daavko daavko commented Nov 26, 2022

The closing reason would otherwise persist from the previous client disconnecting and would appear when listing connected clients via the /list connections command.

Part of #1517

The closing reason would otherwise persist from the previous client disconnecting and would appear when listing connected clients via "/list connections".
@jwrober jwrober self-requested a review November 26, 2022 16:44
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwrober jwrober merged commit 2aaf108 into longturn:master Nov 26, 2022
@daavko daavko deleted the connection-closing-reason-fix branch November 26, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants