Migrate to go-libp2p-tls #43
Conversation
|
Blocked by libp2p/go-libp2p-tls#7 as well as a go-conn-security version bump within go-libp2p-tls (conflicting types) |
Ichbinjoe
force-pushed
the
feat/libp2p-tls
branch
from
aef43f2 to
f0b88d6
Compare
|
This fails since its dependencies were not updated. On my local system with test dependency this passes. This is still blocked on libp2p/go-libp2p-tls#7. I removed two tests since they no longer make sense - the server isn't able to validate the client ID against the certificate it receives, so it doesn't make sense to check to be sure who connected to us is someone we expected to connect to us, since that concept doesn't exist anymore. In addition, this behavior can probably be tested instead in the go-libp2p-tls package in the future. |
There was a problem hiding this comment.
For the same reason that #37 can't be merged at this time (which is the same reason we can't merge libp2p/go-libp2p-tls#7), we won't be able to merge this pull request. So this will have to wait until a new version of quic-go is released. This won't happen this year any more, for sure, and might or might not happen in January next year.
|
This is obsolete now that libp2p/go-libp2p-tls#20 has landed. |
Directly closes #18 and libp2p/go-libp2p-tls#4