This repository has been archived by the owner on May 26, 2022. It is now read-only.
only use a single certificate [do not merge] #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
reviewed
Nov 15, 2018
| @@ -21,29 +19,7 @@ const hostname = "quic.ipfs" | |||
| const certValidityPeriod = 180 * 24 * time.Hour | |||
There was a problem hiding this comment.
We might as well just make this infinite, at this point.
|
Closing due to age. #67 contains the updated handshake logic. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21. Closes #23.
We don't have to worry about backwards compatibility if we make sure to not merge this PR before using a new QUIC version.
Please DON'T merge!