reuse code from go-libp2p-tls

[Stebalien]

Given that QUIC is using the standard golang TLS config type, it would be awesome if we could extract this code out into a new library and then re-use the same handshake for TLS over TCP. Something like:

type Identity tls.Config

func NewIdentity(privKey ic.PrivKey) (*Identity, error) { return generateConfig(privKey) }

// for dialing
func (i *Identity) ConfigForPeer(remote ic.PubKey) (*tls.Config, error) {
  // clone the config and set the validator.
}

func KeyFromChain([]*x509...) (ic.PubKey, error) { ... }

(and any other useful helper functions you can think of)

[marten-seemann]

I like this idea. I thought about that before, but decided to leave this code as part of the QUIC package for now, since QUIC provides us with an easy way to roll out new versions of the handshake protocol. We’ll have to solve that separately if we want to reuse this code.

[Stebalien]

@marten-seemann this is a low-effort issue that would have an extremely high impact (allowing us to add TLS support with almost no effort). Is there any chance we can up the priority on this?

[marten-seemann]

Sure!

[carsonfarmer]

What's the latest on this work? We're very interested in #60. Happy to provide additional use-cases, or even PRs/code help.

[raulk]

I believe go-libp2p-tls is ready. We need to update go-libp2p-quic-transport to use it. Is that correct, @marten-seemann?

[Stebalien]

See #60 (comment). Basically, hard to integrate our quic library as-is.