Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

QUIC transport constructor fails with ed25519 keys #60

Closed
vyzo opened this issue May 1, 2019 · 8 comments · Fixed by #67
Closed

QUIC transport constructor fails with ed25519 keys #60

vyzo opened this issue May 1, 2019 · 8 comments · Fixed by #67
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@vyzo
Copy link
Contributor

vyzo commented May 1, 2019

Trying to bring up some relays using ed25519 keys, and I run into this:

May 01 18:14:27 ip-172-31-47-2 relay.sh[13132]: 2019/05/01 18:14:27 transport constructor github.com/libp2p/go-libp2p-quic-transport.NewTransport failed: unsupported key type for TLS
@vyzo vyzo added the kind/bug A bug in existing code (including security flaws) label May 1, 2019
@vyzo
Copy link
Contributor Author

vyzo commented May 1, 2019

So basically we can't use QUIC with ed25519 keys.

@Stebalien
Copy link
Member

We need to switch to the new TLS handshake, IIRC.

@vyzo
Copy link
Contributor Author

vyzo commented May 1, 2019

Is there a quic(k) remedy for this so that we can use it now?

@Stebalien
Copy link
Member

Not really.

@xaionaro
Copy link

xaionaro commented Jul 1, 2019

I've just added a PR: #65

But it requires Go1.13

@Kubuxu
Copy link
Member

Kubuxu commented Jul 1, 2019

Yeah, we need to wait for Go1.13 as they've just introduced ed25519 support in TLS and included ed25519 in the standard library.

@marten-seemann
Copy link
Collaborator

We should probably rather reuse the code from the TLS package (see #18). In addition to code reuse, this will allow us to use all key types. Unfortunately, since QUIC doesn't have a separate net.Conn per connection, this is not trivial though.

@xaionaro
Copy link

xaionaro commented Jul 2, 2019

We should probably rather reuse the code from the TLS package (see #18). In addition to code reuse, this will allow us to use all key types.

I've added a comment in the PR: #65 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants