implement the new handshake #20
Conversation
| if err != nil { | ||
| return nil, fmt.Errorf("unmarshalling public key failed: %s", err) | ||
| } | ||
| certKeyPub, err := x509.MarshalPKIXPublicKey(cert.PublicKey) |
There was a problem hiding this comment.
| func keyToCertificate(sk ic.PrivKey) (crypto.PrivateKey, *x509.Certificate, error) { | ||
| sn, err := rand.Int(rand.Reader, big.NewInt(1<<62)) | ||
| func keyToCertificate(sk ic.PrivKey) (*tls.Certificate, error) { | ||
| certKey, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader) |
There was a problem hiding this comment.
Are there any other curves we can use...?
There was a problem hiding this comment.
The Go TLS implementation doesn't support P224, and P256 is curve that produces the smallest signatures. We could also use P384 and P512.
There was a problem hiding this comment.
keyToCertificate does (as well as secp256k1), but the Go standard library doesn't. This was one of the reasons we had to invent this new handshake protocol.
There was a problem hiding this comment.
Ahh, I made a mistake and thought it was ecdh not ecdsa. (curve25519 is DH, ed25519 is signature).
marten-seemann
force-pushed
the
new-handshake
branch
from
6613471 to
8e61f12
Compare
marten-seemann
force-pushed
the
new-handshake
branch
from
8e61f12 to
11bbc4e
Compare
There was a problem hiding this comment.
Can't say I'm a crypto expert, but logically LGTM. Minor comments here, and I defer to @Kubuxu and @Stebalien for final approval. Thanks for the great work, @marten-seemann! 🎉
Co-Authored-By: marten-seemann <[email protected]>
marten-seemann
force-pushed
the
new-handshake
branch
from
57a5a79 to
d9950d0
Compare
use ChaCha if one of the peers doesn't have AES hardware support
marten-seemann
force-pushed
the
new-handshake
branch
from
3f4a541 to
663747a
Compare
use a prefix when signing the public key
When resuming a session using session tickets, no certificate chain is presented, and the callbacks needed to verify the peer identity would not be called.
|
@Kubuxu, @Stebalien I just merged the TLS spec. Can you please review this PR now? |
Please read libp2p/specs#151.