-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename COC file so that GitHub can identify it #2700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks!
/assign @idvoretskyi |
/hold Let's make sure it works in kubernetes-sigs/kind#31. |
/approve But we'll likely need to update links across the repo and docs? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: castrojo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unfortunately this change didn't work in two other repos we tested it in.
Probably we should move them back and contact GitHub
…On Mon, Sep 24, 2018, 05:40 k8s-ci-robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *castrojo
<#2700 (comment)>*
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- OWNERS <https://github.com/kubernetes/community/blob/master/OWNERS>
[castrojo]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#2700 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4BqwPDGsoSBz8ks-GTaCjkP0LpNh9Mks5ueNLbgaJpZM4W1ZAW>
.
|
We are reaching out to GitHub. I'll update here based on what we hear. |
From GitHub's reply:
Will let the CoC committee take it forward. Closing this PR since this won't help. |
@nikhita: Closing this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@BenTheElder pointed out that our CoC is not identified by GitHub: https://github.com/kubernetes/community/community.
Looks like it needs to be named as
CODE_OF_CONDUCT.md
: https://help.github.com/articles/adding-a-code-of-conduct-to-your-project/./sig contributor-experience
/kind bug