Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename COC file so that GitHub can identify it #2700

Closed
wants to merge 1 commit into from

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Sep 22, 2018

@BenTheElder pointed out that our CoC is not identified by GitHub: https://github.com/kubernetes/community/community.

Looks like it needs to be named as CODE_OF_CONDUCT.md: https://help.github.com/articles/adding-a-code-of-conduct-to-your-project/.

/sig contributor-experience
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 22, 2018
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2018
@BenTheElder
Copy link
Member

/assign @idvoretskyi

@nikhita
Copy link
Member Author

nikhita commented Sep 22, 2018

/hold

Let's make sure it works in kubernetes-sigs/kind#31.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2018
@castrojo
Copy link
Member

/approve

But we'll likely need to update links across the repo and docs?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2018
@BenTheElder
Copy link
Member

BenTheElder commented Sep 24, 2018 via email

@nikhita
Copy link
Member Author

nikhita commented Sep 25, 2018

We are reaching out to GitHub. I'll update here based on what we hear.

@nikhita
Copy link
Member Author

nikhita commented Sep 25, 2018

From GitHub's reply:

Currently, the tool will only check specifically for code of conduct files that we recognize, not just the existence of a CODE_OF_CONDUCT.md. This was an intentional choice made to avoid giving folks a checkmark if they've got a file full of content that is not actually a code of conduct.

Will let the CoC committee take it forward.

Closing this PR since this won't help.
/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this PR.

In response to this:

From GitHub's reply:

Currently, the tool will only check specifically for code of conduct files that we recognize, not just the existence of a CODE_OF_CONDUCT.md. This was an intentional choice made to avoid giving folks a checkmark if they've got a file full of content that is not actually a code of conduct.

Will let the CoC committee take it forward.

Closing this PR since this won't help.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants