Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move COC so github will recognize it #31

Merged
merged 1 commit into from
Sep 22, 2018
Merged

move COC so github will recognize it #31

merged 1 commit into from
Sep 22, 2018

Conversation

BenTheElder
Copy link
Member

cc @nikhita it will be quicker to test here since I have top level approve
xref: kubernetes/community#2700

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2018
@k8s-ci-robot k8s-ci-robot requested a review from amwat September 22, 2018 18:46
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2018
@nikhita
Copy link
Member

nikhita commented Sep 22, 2018

awesome, thanks!

/lgtm

@k8s-ci-robot
Copy link
Contributor

@nikhita: changing LGTM is restricted to assignees, and only kubernetes-sigs/kind repo collaborators may be assigned issues.

In response to this:

awesome, thanks!

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member Author

adding LGTM per above.

@BenTheElder BenTheElder added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 71ed075 into kubernetes-sigs:master Sep 22, 2018
This was referenced Sep 22, 2018
Closed
Closed
@BenTheElder BenTheElder deleted the github-coc branch September 22, 2018 19:12
@tao12345666333 tao12345666333 mentioned this pull request Sep 23, 2018
Closed
@idvoretskyi
Copy link
Member

Late
/lgtm

:)

@BenTheElder BenTheElder mentioned this pull request Sep 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat Awaiting requested review from amwat

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @nikhita @idvoretskyi