Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix COC link. #32

Closed

Conversation

tao12345666333
Copy link
Member

No description provided.

Signed-off-by: Jintao Zhang <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Welcome @tao12345666333! It looks like this is your first PR to kubernetes-sigs/kind 🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tao12345666333
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: quinton-hoole

If they are not already assigned, you can assign the PR to them by writing /assign @quinton-hoole in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2018
@tao12345666333
Copy link
Member Author

ref: #31
kubernetes/community#2700

@tao12345666333
Copy link
Member Author

/assign @BenTheElder

@BenTheElder
Copy link
Member

/ok-to-test
/hold
I think we're going to wait and see if we still want to move this as so far github is not teating it any differently :| cc @nikhita

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2018
@BenTheElder
Copy link
Member

Thanks for the PR btw, if we do decide to keep the move I'll merge this ASAP, otherwise I'm going to hold it just a little longer so there's one less thing to revert.

@tao12345666333
Copy link
Member Author

@BenTheElder Thanks. 👍

As described in the GitHub help docs , maybe it's the "best practices".

@nikhita
Copy link
Member

nikhita commented Sep 25, 2018

@tao12345666333 thanks for the PR! However, as per GitHub's reply (kubernetes/community#2700 (comment)), we won't be renaming our code of conduct file. #33 just got merged.

Closing.
/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this PR.

In response to this:

@tao12345666333 thanks for the PR! However, as per GitHub's reply (kubernetes/community#2700 (comment)), we won't be renaming our code of conduct file. #33 just got merged.

Closing.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tao12345666333
Copy link
Member Author

@nikhita Thanks.

stg-0 pushed a commit to stg-0/kind that referenced this pull request Feb 7, 2023
…g_optional_autoscaler

Feature/adding optional autoscaler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants