Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "move COC so github will recognize it" #9569

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Sep 25, 2018

This reverts commit 1f9b19e.

Ref: kubernetes/community#2700 (comment)

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2018
@BenTheElder
Copy link
Member

/lgtm Thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2018
@nikhita
Copy link
Member Author

nikhita commented Sep 25, 2018

I'm so confused with prow today...this applied approved but not lgtm (and even with the trailing text after /lgtm). 🤔

@BenTheElder
Copy link
Member

yeah lgtm and approve are acting up... I had this morning in kind but the opposite (my lgtm added lgtm but not approve...) @cjwagner

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 12bb688 into kubernetes:master Sep 25, 2018
@cjwagner
Copy link
Member

@BenTheElder The /lgtm wasn't picked up by the lgtm plugin because you included text on the same line. The approve plugin uses a more generic command matching regexp that does notice the /lgtm even though there is trailing text.

If you link to the issue you saw this morning I can take a look.

@cjwagner
Copy link
Member

@BenTheElder lgtm_acts_as_approve is not enabled for the kubernetes-sigs/kind repo:

- repos:
- kubernetes-client
- kubernetes-csi
- kubernetes-sigs
- client-go/unofficial-docs
implicit_self_approve: true

@BenTheElder
Copy link
Member

I see. Thanks. I find it surprising that we configure this differently for so many repos :/

@nikhita nikhita deleted the fix-coc branch September 26, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants