Helm Chart bug, can not use a cascading expander with priority in it

[AndrewFarley]

Fixes #4502

[k8s-ci-robot]

Welcome @AndrewFarley!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrewFarley
To complete the pull request process, please assign gjtempleton after the PR has been reviewed.
You can assign the PR to them by writing /assign @gjtempleton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndrewFarley]

Related to: #4321

With both of these fixed, proper support for expander priority will be fully capable in the helm chart

[AndrewFarley]

I'm fully CLA'd, please @ me if you need anything else. Please fix, accept, and publish new Helm Charts ASAP if possible. Thanks

[AndrewFarley]

Found a bug, fixed role.yaml which also used the old eq logic. Fixed to use contains logic, now the output is exactly the same.

[gjtempleton]

Hi @AndrewFarley, thanks for the PR!

The chart version will need a bump here before we can merge it.

/assign @gjtempleton

[AndrewFarley]

Note: Safe to merge now, but this feature won't work until #4504 is resolved.

[k8s-ci-robot]

@AndrewFarley: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AndrewFarley]

FYI, it looks like someone else fixed this in another MR/PR in e4cf3b0 but I think perhaps theirs was incomplete and missing some stanzas I included to handle all edge cases. Can someone/whomever merged that verify the merged code against my code in this MR to ensure it handled all edge cases?

[gjtempleton]

Sorry, my bad in terms of reviewing order. I assume from the merging of #4665 and your update to the comment there, we can close this PR now?

[AndrewFarley]

Yep, closed