Bug: Helm Chart bug, can not use a cascading expander with priority in it, configmap missing

[AndrewFarley]

Issue

The conditional creation logic for the priority-expander-configmap.yaml:

{{- if hasKey .Values.extraArgs "expander" }}
{{- if and (.Values.expanderPriorities) (eq .Values.extraArgs.expander "priority") -}}

Directly conflicts with ability to pass multiple expanders to cascade, info from the FAQ:

Multiple expanders may be passed, i.e. .cluster-autoscaler --expander=priority,least-waste

which results in it not being possible to set...

  extraArgs:
    expander: priority,least-waste  # <--- this
  expanderPriorities: |-
    10:
      - '.*g2\..*'

And have it still set the expanderPriorities configmap. Right now I can set this expander value above and it works properly, except the configmap is not created because of this flawed conditional logic.

Bugfix

Possible bugfix is to change the "eq" to contains in that second line, I'm submitting an MR now.

[ddelange]

Can this issue be closed as of #4665?

[AndrewFarley]

Yep!