-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helm chart support for multiple expanders including "priority" #4665
feat: add helm chart support for multiple expanders including "priority" #4665
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @JoshVee! |
/assign @gjtempleton |
1634437
to
03b43df
Compare
529ab3e
to
5752f50
Compare
5752f50
to
f9f389d
Compare
Thanks for this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, JoshVee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gjtempleton Please review this MR against the other one I did, I don't have time to confirm, but based on a brief look at the changelogs, you may have missed a few places to ensure this MR does what it should. See: #4503 EDIT: Nevermind, after closer inspection looks like you got them all. Great work, cheers! |
Which component this PR applies to?
helm charts
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for multiple expanders to the Helm chart, as per #4233.
This change allows the "priority" expander to be used along with other expanders.
Which issue(s) this PR fixes:
N\A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: