-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HELM] Fix missing yaml conversion for expander priorities #4321
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @bwhaley! |
Oh, I just noticed #3776. This fix seems worthwhile though, no? This interface is more intuitive. |
I've signed the CLA. |
098ddc0
to
16d1598
Compare
BUMP, this bit me in the ass, please accept this PR |
/assign @gjtempleton Hey, sorry for the delay in this being reviewed, I use being assigned as my working filter (hence the ci-robot's advice to assign PRs) so it slipped through the gaps. You're going to need to bump the chart version here to allow this to be published. |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Consider it bumped! |
/check-cla |
/cc gjtempleton |
79fa37a
to
5f80dd6
Compare
5f80dd6
to
a2f9bdb
Compare
Thanks for that! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bwhaley, gjtempleton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This should fix an error with Helm when passing expanderPriorities: