Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA-Chart - 9.10.0, 9.10.1, 9.10.2 and 9.10.3 Releases #4180

Merged
merged 1 commit into from
Jul 26, 2021
Merged

CA-Chart - 9.10.0, 9.10.1, 9.10.2 and 9.10.3 Releases #4180

merged 1 commit into from
Jul 26, 2021

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented Jul 5, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2021
@gjtempleton gjtempleton changed the title CA-Chart - 9.10.0 Release CA-Chart - 9.10.0 and 9.10.1 Releases Jul 8, 2021
@gjtempleton
Copy link
Member Author

Holding pending addressing of non SemVer release.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@gjtempleton gjtempleton force-pushed the CA-9.10.0-Release branch 2 times, most recently from 9754c2a to e2c32b6 Compare July 8, 2021 13:16
@gjtempleton
Copy link
Member Author

Updated with 9.10.2 release
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@MarcusNoble MarcusNoble mentioned this pull request Jul 9, 2021
Closed
@MarcusNoble
Copy link
Contributor

Is there anything still preventing this from being merged? Would be good to get the latest version available in the chart registry as the releases are already showing in GitHub.

stevehipwell
stevehipwell reviewed Jul 12, 2021
View reviewed changes
index.yaml Outdated
type: application
urls:
- https://github.com/kubernetes/autoscaler/releases/download/cluster-autoscaler-chart-9.10.01/cluster-autoscaler-9.10.01.tgz
version: 9.10.01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest manually fixing the version here before merging.

Suggested change
version: 9.10.01
version: 9.10.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, done as suggested.

@gjtempleton gjtempleton changed the title CA-Chart - 9.10.0 and 9.10.1 Releases CA-Chart - 9.10.0, 9.10.1 and 9.10.2 Releases Jul 12, 2021
@gjtempleton
Copy link
Member Author

/assign @mwielgus

@haines haines mentioned this pull request Jul 13, 2021
Closed
@Sebor
Copy link
Contributor

Sebor commented Jul 21, 2021 •
edited
Loading

What about Not mergeable. Needs lgtm label.?

@stevehipwell
Copy link
Contributor

Could we get this merged ASAP?

@gjtempleton
Copy link
Member Author

gjtempleton commented Jul 22, 2021 •
edited
Loading

@MaciekPytel could you give this a review please?

@pierluigilenoci
Copy link
Contributor

@mwielgus @MaciekPytel @bskiba could you please take a look?

@gjtempleton gjtempleton changed the title CA-Chart - 9.10.0, 9.10.1 and 9.10.2 Releases CA-Chart - 9.10.0, 9.10.1, 9.10.2 and 9.10.3 Releases Jul 26, 2021
@MaciekPytel
Copy link
Contributor

/lgtm

Sorry I missed it before.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit ee1b608 into kubernetes:gh-pages Jul 26, 2021
@gjtempleton gjtempleton mentioned this pull request Jul 26, 2021
Merged
@gjtempleton gjtempleton deleted the CA-9.10.0-Release branch July 26, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehipwell stevehipwell stevehipwell left review comments

@bskiba bskiba Awaiting requested review from bskiba

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@MaciekPytel MaciekPytel

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gjtempleton @k8s-ci-robot @MarcusNoble @Sebor @stevehipwell @pierluigilenoci @MaciekPytel @jbartosik @mwielgus