[chart] Add multi string arg support

[stevehipwell]

Enable extraArgs to contain multi-string arguments via an ignored _x suffix.

Fixes #3673.

[stevehipwell]

/assign @gjtempleton

[stevehipwell]

I'm not sure why the Helm Docs action failed as I haven't touched the chart README?

[gjtempleton]

It'll be what I mentioned here, unfortunately: #3673 (comment) (I'd planned to address it in #4208, but that's not been merged yet.)

[stevehipwell]

@gjtempleton I've contributed before (I think) and the other actions ran fine. I've grabbed your changes from PR #4208 but the Helm Docs action is still failing?

[gjtempleton]

You'll need to re-run helm-docs against the chart, your change to the comment block on the extraArgs will be pulled into the README by it. What I get when I run it:

-| extraArgs | object | `{"logtostderr":true,"stderrthreshold":"info","v":4}` | Additional container arguments. Refer to https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#what-are-the-parameters-to-ca for the full list of cluster autoscaler parameters and their default values. |
+| extraArgs | object | `{"logtostderr":true,"stderrthreshold":"info","v":4}` | Additional container arguments. Refer to https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#what-are-the-parameters-to-ca for the full list of cluster autoscaler parameters and their default values. everything after the first _ will be ignored allowing the use of multi-string arguments |

Edit:

This is mentioned at the root of the charts directory, but do you think it would be more obvious if we had a CONTRIBUTING file in the chart itself?

[stevehipwell]

Thanks @gjtempleton, I'd just figured it out myself although adding --exit-code to the git diff command in the action might make it easier to figure out the desired behaviour. A contributing file might also help or maybe a PR template?

[gjtempleton]

Thanks, I'm having a look into what the flow with multiple PR templates for different components within the repo might look like at the moment, but good call on the workflow exit code, will add that.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [gjtempleton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stevehipwell]

@gjtempleton is it still a manual process to get a chart released after the PR is merged?

[gjtempleton]

🤦 This'll be available once #4227 is merged.